From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/kodi-pvr-stalker: Needs jsoncpp
Date: Thu, 1 Oct 2015 23:46:08 +0300 [thread overview]
Message-ID: <20151001204608.GB13467@tarshish> (raw)
In-Reply-To: <XnsA526E49B29BD5berndkuhlsPkbjNfxxIA@bernd-kuhls.de>
Hi Bernd,
On Thu, Oct 01, 2015 at 10:28:23PM +0200, Bernd Kuhls wrote:
> Baruch Siach <baruch@tkos.co.il> wrote in
> news:20151001202438.GE3337 at tarshish:
> > On Thu, Oct 01, 2015 at 10:13:57PM +0200, Bernd Kuhls wrote:
> >> diff --git a/package/kodi-pvr-stalker/Config.in
> >> b/package/kodi-pvr-stalker/Config.in
> >> index b327fd8..0e6143a 100644
> >> --- a/package/kodi-pvr-stalker/Config.in
> >> +++ b/package/kodi-pvr-stalker/Config.in
> >> @@ -1,7 +1,12 @@
> >> config BR2_PACKAGE_KODI_PVR_STALKER
> >> bool "kodi-pvr-stalker"
> >> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
> >
> > Also BR2_INSTALL_LIBSTDCPP.
>
> imho this is not necessary, BR2_PACKAGE_KODI_PVR_STALKER can only be selected
> if BR2_PACKAGE_KODI is true and BR2_PACKAGE_KODI already depends on BR2
> _INSTALL_LIBSTDCPP.
In that case the comment doesn't even show when the toolchain lacks C++
support, so I guess you can just omit C++ from the toolchain requirements
comment.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-10-01 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 20:13 [Buildroot] [PATCH v2 1/1] package/kodi-pvr-stalker: Needs jsoncpp Bernd Kuhls
2015-10-01 20:24 ` Baruch Siach
2015-10-01 20:28 ` Bernd Kuhls
2015-10-01 20:46 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001204608.GB13467@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox