From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: Remove useless printf
Date: Sun, 4 Oct 2015 12:27:07 +0100 [thread overview]
Message-ID: <20151004112707.GA7334@free.fr> (raw)
In-Reply-To: <1443957460-26432-1-git-send-email-maxime.hadjinlian@gmail.com>
Maxime, All,
On 2015-10-04 13:17 +0200, Maxime Hadjinlian spake thusly:
> Introduced by previous patch 0f75b2635ee564fbbdb9ea631cf39fa8731d6d6c,
> this printf doesn't serve any purposes.
This is even worth than that. It actually breaks the build because there
is not format to printf:
printf: usage: printf [-v var] format [arguments]
So the glibc build fails.
With that fixed in the commit log;
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
And I think this would also be valid;
Reported-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
;-)
Regards,
Yann E. MORIN.
> ---
> toolchain/helpers.mk | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index a4fa815..1452ec6 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -79,9 +79,7 @@ copy_toolchain_lib_root = \
> fi ; \
> LIBPATH="`readlink -f $${LIBPATH}`"; \
> done; \
> - done; \
> -\
> - printf
> + done
>
> #
> # Copy the full external toolchain sysroot directory to the staging
> --
> 2.5.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-10-04 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 11:17 [Buildroot] [PATCH] toolchain: Remove useless printf Maxime Hadjinlian
2015-10-04 11:27 ` Yann E. MORIN [this message]
2015-10-04 11:29 ` Maxime Hadjinlian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004112707.GA7334@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox