Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/3] skeleton: Clean up profile file
Date: Sun, 4 Oct 2015 15:55:11 +0100	[thread overview]
Message-ID: <20151004155511.047ca1ce@free-electrons.com> (raw)
In-Reply-To: <1443884002-13585-1-git-send-email-maxime.hadjinlian@gmail.com>

Maxime,

On Sat,  3 Oct 2015 16:53:20 +0200, Maxime Hadjinlian wrote:
> There's a lot of code in /etc/profile, which doesn't really belong in a
> minimal default skeleton.
> 
> Also, add an 'unset i' to avoid clutter.
> 
> If the user has a specific needs, it needs to be added in
> /etc/profile.d/ by a post-build script.
> 
> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v3 -> v4:
>     - Enclose export PS1 in a "if [ "$PS1" ]; then" so it's only for an
>       interactive session.
>     - Fix commit log (add unset i)
> v1 -> v2:
>     - Don't change indent and don't fix 'pretty' stuff
>     - Keep PS1 , PAGER and EDITOR setted.
>     - At the end of the for loop, add unset i
> ---
>  system/skeleton/etc/profile         | 56 +++++--------------------------------
>  system/skeleton/etc/profile.d/umask |  1 +
>  2 files changed, 8 insertions(+), 49 deletions(-)
>  create mode 100644 system/skeleton/etc/profile.d/umask

All three patches applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-10-04 14:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-03 14:53 [Buildroot] [PATCH v4 1/3] skeleton: Clean up profile file Maxime Hadjinlian
2015-10-03 14:53 ` [Buildroot] [PATCH v4 2/3] skeleton: Remove bash specific files Maxime Hadjinlian
2015-10-04 10:12   ` Luca Ceresoli
2015-10-03 14:53 ` [Buildroot] [PATCH v4 3/3] skeleton: Pretty fixes for /etc/profile Maxime Hadjinlian
2015-10-04 10:12   ` Luca Ceresoli
2015-10-04 10:12 ` [Buildroot] [PATCH v4 1/3] skeleton: Clean up profile file Luca Ceresoli
2015-10-04 14:55 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151004155511.047ca1ce@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox