From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 10 Oct 2015 11:54:03 +0200 Subject: [Buildroot] [PATCH 1/1] bash: add default bash settings In-Reply-To: <1444259824-6246-1-git-send-email-dvanarnem@cmlab.biz> References: <1444259824-6246-1-git-send-email-dvanarnem@cmlab.biz> Message-ID: <20151010115403.7cf295f0@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear David Van Arnem, On Wed, 7 Oct 2015 17:17:04 -0600, David Van Arnem wrote: > Settings that were bash-specific were previously removed from > system/skeleton/etc/profile. This measn that users using bash no longer > get the "normal" bash prompt with [user at host dir]#/$, and only get #/$. > This commit adds back the bash-specific settings, but adds them to the > bash package so they are only used when bash is installed on the target > system. > > bash_profile.sh contains the variables, aliases, and color profile that > were previously in system/skeleton/etc/profile. The changes to bash.mk > use a post-install hook to install bash_profile.sh to the target > filesystem, where it will later be sourced by /etc/profile when a bash > shell is started. > > Signed-off-by: David Van Arnem Thanks for your patch. Following the comments from Maxime Hadjinlian on your patch, I've marked it as "Changes Requested" in our patch tracking system. Please resubmit a new version of your patch that takes into account the comments made by Maxime. Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com