Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/shairport-sync: bump to version 2.4.1
Date: Sun, 11 Oct 2015 22:20:50 +0200	[thread overview]
Message-ID: <20151011202050.GC24916@free.fr> (raw)
In-Reply-To: <20151011185819.GI2451@tarshish>

Baruch, J?rg, All,

On 2015-10-11 21:58 +0300, Baruch Siach spake thusly:
> On Sun, Oct 11, 2015 at 08:52:40PM +0200, J?rg Krause wrote:
> > Remove applied upstream patch.
> > 
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > ---
> >  package/shairport-sync/shairport-sync.mk | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/package/shairport-sync/shairport-sync.mk b/package/shairport-sync/shairport-sync.mk
> > index 36d5b82..bf1409b 100644
> > --- a/package/shairport-sync/shairport-sync.mk
> > +++ b/package/shairport-sync/shairport-sync.mk
> > @@ -4,13 +4,12 @@
> >  #
> >  ################################################################################
> >  
> > -SHAIRPORT_SYNC_VERSION = 2.4
> > +SHAIRPORT_SYNC_VERSION = 2.4.1
> >  SHAIRPORT_SYNC_SITE = $(call github,mikebrady,shairport-sync,$(SHAIRPORT_SYNC_VERSION))
> >  
> >  SHAIRPORT_SYNC_LICENSE = MIT, BSD-3c
> >  SHAIRPORT_SYNC_LICENSE_FILES = LICENSES
> >  SHAIRPORT_SYNC_DEPENDENCIES = alsa-lib libconfig libdaemon popt host-pkgconf
> > -SHAIRPORT_SYNC_PATCH = https://github.com/mikebrady/shairport-sync/commit/6ae067af1f695e615415cde69a506ad330dbc45b.patch
> >  
> >  # Touching configure.ac with the patches
> >  SHAIRPORT_SYNC_AUTORECONF = YES
> 
> Is this still needed, then? Maybe the comment just needs an update (git clone, 
> no configure)?

We do not have any bundled patch either, and that backported-from-upstream
patch was not touching configure.ac:

     mdns_dns_sd.c      | 2 +-
     mdns_tinysvcmdns.c | 2 +-
     2 files changed, 2 insertions(+), 2 deletions(-)

So it is not J?rg forgetting to update the comment; it was already
wrong.

But it should be fixed nonetheless, I agree.

J?rg, care to resend your patch which also updates the comment as
suggested by Baruch, please? I'm marking this patch as "Changes
Requested" on patchowrk.

Thanks!

Regards,
Yann E. MORIN.


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-10-11 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 18:52 [Buildroot] [PATCH 1/1] package/shairport-sync: bump to version 2.4.1 Jörg Krause
2015-10-11 18:58 ` Baruch Siach
2015-10-11 20:20   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151011202050.GC24916@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox