From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] [arm64 uboot] Resolved compilation issue for arm64 uboot
Date: Mon, 12 Oct 2015 19:39:42 +0200 [thread overview]
Message-ID: <20151012193942.75ee6483@free-electrons.com> (raw)
In-Reply-To: <1444664954-64180-1-git-send-email-matthew.weber@rockwellcollins.com>
Dear Matt Weber,
On Mon, 12 Oct 2015 10:49:14 -0500, Matt Weber wrote:
> This patch has been added to resolve the compilation issue
> of arm64 uboot.
>
> For aarch64 architecture, kernel uses arm64 terminology and thus from
> top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which
> then passed to uboot compilation. But, it causes compilation issue
> while including architecture specific Makefile under
> arch/$(ARCH)/Makefile as uboot uses top-level system architecture as
> arm only.
I'm not a native english speaker, but the wording of this sentence
doesn't seem quite right.
The title of the commit should be:
uboot: <something>
> +# For aarch64 architecture, kernel uses arm64 terminology and thus from
> +# # top-level Makefile KERNEL_ARCH is modified to arm64 for aarch64 which
> +# # then passed to uboot compilation. But, it causes compilation issue
> +# # while including architecture specific Makefile under arch/$(ARCH)/Makefile
> +# # as uboot uses top-level system architecture as arm only.
Double hashes a the beginning of each line -> not good.
Care to fix that up (especially rewording the commit log and comment) ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-12 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:49 [Buildroot] [PATCH 1/1] [arm64 uboot] Resolved compilation issue for arm64 uboot Matt Weber
2015-10-12 17:39 ` Thomas Petazzoni [this message]
2015-10-12 18:51 ` Matthew Weber
2015-10-12 18:56 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012193942.75ee6483@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox