Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] musl: Honor BR2_STATIC_LIBS / BR2_SHARED_LIBS
Date: Wed, 14 Oct 2015 23:35:07 +0200	[thread overview]
Message-ID: <20151014233507.23a93657@free-electrons.com> (raw)
In-Reply-To: <1444796977-23004-1-git-send-email-chaduffy@cisco.com>

Charles,

On Tue, 13 Oct 2015 23:29:37 -0500, Charles Duffy wrote:
> From: Charles Duffy <charles@dyfis.net>
> 
> Signed-off-by: Charles Duffy <chaduffy@cisco.com>

Thanks for the patch!

> diff --git a/package/musl/musl.mk b/package/musl/musl.mk
> index 22589f5..aca78ab 100644
> --- a/package/musl/musl.mk
> +++ b/package/musl/musl.mk
> @@ -28,7 +28,9 @@ define MUSL_CONFIGURE_CMDS
>  			--host=$(GNU_TARGET_NAME) \
>  			--prefix=/usr \
>  			--libdir=/lib \
> -			--disable-gcc-wrapper)
> +			--disable-gcc-wrapper \
> +			$(if $(BR2_STATIC_LIBS),--disable-shared) \
> +			$(if $(BR2_SHARED_LIBS),--disable-static))

Could you instead try the following change:

-			--disable-gcc-wrapper)
+			--disable-gcc-wrapper \
+			$(SHARED_STATIC_LIBS_OPTS))


The SHARED_STATIC_LIBS_OPTS variable, defined in package/Makefile.in,
already contains the right combination of
--{enable,disable}-{static,shared} depending on BR2_STATIC_LIBS,
BR2_SHARED_LIBS and BR2_STATIC_SHARED_LIBS.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-14 21:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14  4:29 [Buildroot] [PATCH 1/1] musl: Honor BR2_STATIC_LIBS / BR2_SHARED_LIBS Charles Duffy
2015-10-14 21:35 ` Thomas Petazzoni [this message]
2015-10-14 22:23   ` Charles Duffy
2015-10-15  7:38     ` Thomas Petazzoni
2015-10-18 13:09 ` Thomas Petazzoni
2015-10-18 15:58   ` Yann E. MORIN
2015-10-18 16:18     ` Charles Duffy
2015-10-18 16:33       ` Thomas Petazzoni
2015-10-18 18:52         ` Yann E. MORIN
2015-10-18 19:06         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014233507.23a93657@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox