From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: Fix compile errors in qurl.h / qeglplatformscreen.cpp
Date: Sat, 17 Oct 2015 20:17:26 +0200 [thread overview]
Message-ID: <20151017201726.41a4fa77@free-electrons.com> (raw)
In-Reply-To: <1441286530-63345-1-git-send-email-marc.andre@netline.ch>
Dear Marc Andre,
On Thu, 3 Sep 2015 15:22:10 +0200, Marc Andre wrote:
> Update the already existing fix for EGL/X11 header issue to fix
> an additional problem encountered on my system where I had
> compile errors in qeglplatformscreen.cpp. The problem was related
> to the wrong order of includes. The X11 headers must always be
> included last, as indicated in
> http://lists.qt-project.org/pipermail/development/2013-March/010511.html
>
> I decided instead of adding a new patch to update the existing patch,
> because it is an additional fix for the same problem. If you don't agree
> I am happy to submit a seperate patch.
>
> This version is updated as suggested by Arnout.
>
> Signed-off-by: Marc Andre <marc.andre@netline.ch>
> ---
> package/qt5/qt5base/0003-xcb-egl-fixes.patch | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
Applied, after slightly tweaking the commit log (to avoid sentence at
the first person) and rework the SoB as suggested by Arnout.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-17 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 13:22 [Buildroot] [PATCH] qt5base: Fix compile errors in qurl.h / qeglplatformscreen.cpp Marc Andre
2015-09-04 13:39 ` Vicente Olivert Riera
2015-09-04 15:24 ` Marc Andre
2015-09-04 16:30 ` Arnout Vandecappelle
2015-10-17 18:17 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-02 12:03 Marc
2015-09-02 22:00 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017201726.41a4fa77@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox