Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] dvblast: new package
Date: Sun, 18 Oct 2015 16:06:12 +0200	[thread overview]
Message-ID: <20151018160612.1bb09b23@free-electrons.com> (raw)
In-Reply-To: <1445171651-28330-2-git-send-email-julian@jusst.de>

Dear Julian Scheel,

On Sun, 18 Oct 2015 14:34:11 +0200, Julian Scheel wrote:
> DVBlast is a simple and powerful MPEG-2/TS demux and streaming application.
> 
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> Changelog v2:
> 
> Address review comments by Yann E. Morin (thanks for review!)
> - Complete license information
> - Remove explicit INSTALL_STAGING=no

You should have also removed INSTALL_TARGET = YES, because that's the
default.

> - Fix install command
> 
> The build cmd is not changed to use TARGET_CONFIGURE_OPTS as it breaks the
> build.

A working solution is to pass TARGET_CONFIGURE_OPTS in the environment
of make instead of as an option. This ensures that the CFLAGS += in the
dvblast Makefile are still taken into account.

So, I've applied you patch, with the following changes:

    [Thomas:
     - add missing hash file.
     - rewrap Config.in help text
     - remove unneeded "DVBLAST_INSTALL_TARGET = YES", since this is the
       default behavior
     - pass TARGET_MAKE_ENV in the environment when calling make.
     - use TARGET_CONFIGURE_OPTS instead of just CC/LD.]

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-18 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 12:34 [Buildroot] [PATCH v2 1/2] bitstream: new package Julian Scheel
2015-10-18 12:34 ` [Buildroot] [PATCH v2 2/2] dvblast: " Julian Scheel
2015-10-18 14:06   ` Thomas Petazzoni [this message]
2015-10-18 20:13     ` Julian Scheel
2015-10-18 13:54 ` [Buildroot] [PATCH v2 1/2] bitstream: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151018160612.1bb09b23@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox