From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/mkusers: allow comments in users tables
Date: Sun, 18 Oct 2015 17:55:58 +0200 [thread overview]
Message-ID: <20151018175558.62ec445b@free-electrons.com> (raw)
In-Reply-To: <1445097019-3217-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sat, 17 Oct 2015 17:50:19 +0200, Yann E. MORIN wrote:
> The format of the users table files is non trivial, so it is sometimes
> handy to add comments explaining the syntax (or simply the reason for
> the user) inline in the files.
>
> Ignore empty lines and comment lines prefixed with '#' similar to shell
> or makedevs files.
>
> Packages that defined no user (the vast majority) would cause an empty
> line to be present in the internal users table, hence the reason we
> skipped empty usernames. Now that we ignore empty lines, we no longer
> need to check for empty usernames.
>
> Reported-by: Peter Korsgaard <jacmet@uclibc.org>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <jacmet@uclibc.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> support/scripts/mkusers | 45 ++++++++++++++++++++++++++-------------------
> 1 file changed, 26 insertions(+), 19 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-10-18 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 15:50 [Buildroot] [PATCH] support/mkusers: allow comments in users tables Yann E. MORIN
2015-10-18 15:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018175558.62ec445b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox