From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libdcadec: Add -fPIC to static build, enable shared build
Date: Sun, 18 Oct 2015 21:05:20 +0200 [thread overview]
Message-ID: <20151018210520.0c6971da@free-electrons.com> (raw)
In-Reply-To: <1445184515-6049-1-git-send-email-bernd.kuhls@t-online.de>
Bernd,
On Sun, 18 Oct 2015 18:08:35 +0200, Bernd Kuhls wrote:
> Adding -fPIC fixes
> http://autobuild.buildroot.net/results/a19/a19023e094cbed491444665d6839a9e65a8eee6c/
> http://autobuild.buildroot.net/results/98d/98dde028d1d6199f05c904b498bc39bbaa112aa6/
> http://autobuild.buildroot.net/results/4ff/4ffcae6cae419df35e8ca29d429ee178bcf31882/
> http://autobuild.buildroot.net/results/8ce/8ced16874255ace4923f6b8888c3fca07f28b804/
None of these configurations have BR2_STATIC_LIBS=y, so I fail to see
why adding -fPIC when BR2_STATIC_LIBS=y would fix those issues.
Moreover, using -fPIC for statically linked configurations generally
doesn't make sense: the point of PIC code is to be Position
Independent, which is needed for shared libraries. But not for
statically linked programs.
> The upstream Makefile also allows building a shared library if
> CONFIG_SHARED=1 is added to _BUILD_CMDS.
This probably fixes the problem however.
So, can you explain the addition of -fPIC for BR2_STATIC_LIBS=y
configurations?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-18 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 16:08 [Buildroot] [PATCH 1/1] package/libdcadec: Add -fPIC to static build, enable shared build Bernd Kuhls
2015-10-18 19:05 ` Thomas Petazzoni [this message]
2015-10-18 19:52 ` Samuel Martin
2015-10-18 20:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151018210520.0c6971da@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox