From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Mon, 19 Oct 2015 22:30:09 +0200 Subject: [Buildroot] [PATCH 1/2 v2] package/nodejs: fix architectural dependencies on ARM In-Reply-To: <20151019222710.74159e82@free-electrons.com> References: <03bfe81f7d32e7eb9b032d41d8c720d7ab95cb69.1445277033.git.yann.morin.1998@free.fr> <20151019222710.74159e82@free-electrons.com> Message-ID: <20151019203009.GC3651@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas, All, On 2015-10-19 22:27 +0200, Thomas Petazzoni spake thusly: > On Mon, 19 Oct 2015 19:51:00 +0200, Yann E. MORIN wrote: > > +# Starting with 0.12.x, on ARM, V8 (the JS engine) > > +# requires an armv6+ and a VFPv2+. > > +config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS > > + bool > > + default y > > + depends on !BR2_arm || !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2 > > I would find the following to be a bit easier to understand: > > # On supported architectures other than ARM, no special requirement > default y if !BR2_arm > # On ARM, at least ARMv6+ with VFPv2+ is needed > default y if !BR2_ARM_CPU_ARMV5 && BR2_ARM_CPU_HAS_VFPV2 Yes, tht's a bit better, indeed. Will fix and resend. Thanks! :-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'