Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpkimage: new package
Date: Tue, 20 Oct 2015 09:19:18 +0200	[thread overview]
Message-ID: <20151020091918.79212c0f@free-electrons.com> (raw)
In-Reply-To: <1445291141-6182-1-git-send-email-maxime.hadjinlian@gmail.com>

Maxime,

On Mon, 19 Oct 2015 23:45:41 +0200, Maxime Hadjinlian wrote:

> diff --git a/package/Config.in.host b/package/Config.in.host
> index 1f69687..a4662d7 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -15,6 +15,7 @@ menu "Host utilities"
>  	source "package/imx-usb-loader/Config.in.host"
>  	source "package/lpc3250loader/Config.in.host"
>  	source "package/mke2img/Config.in.host"
> +	source "package/mkpimage/Config.in.host"

Do we really need a visible Config.in option for this tool? Can't it
simply be used as a dependency of U-Boot, as proposed by Jan in his
patch series ?

> diff --git a/package/mkpimage/mkpimage.mk b/package/mkpimage/mkpimage.mk
> new file mode 100644
> index 0000000..d6dcdd2
> --- /dev/null
> +++ b/package/mkpimage/mkpimage.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# mkpimage
> +#
> +################################################################################
> +
> +# source included in the package
> +# came from barebox's repository:
> +# http://git.pengutronix.de/?p=barebox.git;a=blob;f=scripts/socfpga_mkimage.c;h=1a7a66d98841e9f52c3ea49c651286aa1412c9a5;hb=HEAD
> +HOST_MKPIMAGE_SOURCE =
> +HOST_MKPIMAGE_LICENSE = GPLv2
> +
> +define HOST_MKPIMAGE_BUILD_CMDS
> +    $(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS) \
> +        package/mkpimage/mkpimage.c -o $(@D)/mkpimage

Use tabs for indentation.

> +endef
> +
> +define HOST_MKPIMAGE_INSTALL_CMDS
> +    $(INSTALL) -D -m 755 $(@D)/mkpimage $(HOST_DIR)/usr/bin/mkpimage

Ditto.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-10-20  7:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 21:45 [Buildroot] [PATCH] mpkimage: new package Maxime Hadjinlian
2015-10-19 16:24 ` [Buildroot] [PATCH 0/4] Attempt to improve support for Altera SoC FPGA boards Jan Viktorin
2015-10-19 16:24   ` [Buildroot] [PATCH 1/4] mkpimage: new host package Jan Viktorin
2015-10-19 19:04     ` Maxime Hadjinlian
2015-10-19 20:53       ` Thomas Petazzoni
2015-10-19 21:06         ` Yann E. MORIN
2015-10-19 21:12           ` Maxime Hadjinlian
2015-10-19 21:24             ` Jan Viktorin
2015-10-19 21:36               ` Maxime Hadjinlian
2015-10-19 22:10                 ` Jan Viktorin
2015-10-19 22:12                   ` Maxime Hadjinlian
2015-10-20 10:41                     ` Jan Viktorin
2015-10-19 21:12           ` Thomas Petazzoni
2015-10-19 16:24   ` [Buildroot] [PATCH 2/4] boot/uboot: compute CRC on SPLs for Altera SoC FPGA Jan Viktorin
2015-10-19 16:24   ` [Buildroot] [PATCH 3/4] socfpga: update readme for sockit/socdk boards Jan Viktorin
2015-10-19 16:24   ` [Buildroot] [PATCH 4/4] socfpga: note about unnecessary mkpimage of SPL Jan Viktorin
2015-10-19 16:30   ` [Buildroot] [PATCH 0/4] Attempt to improve support for Altera SoC FPGA boards Jan Viktorin
2015-10-20 11:32   ` [Buildroot] [PATCH v2 0/7] " Jan Viktorin
2015-10-20 11:32     ` [Buildroot] [PATCH v2 1/7] mkpimage: new host package Jan Viktorin
2016-03-22 22:53       ` Thomas Petazzoni
2015-10-20 11:32     ` [Buildroot] [PATCH v2 2/7] boot/uboot: compute CRC on SPLs for Altera SoC FPGA Jan Viktorin
2015-10-20 11:36       ` Jan Viktorin
2016-03-22 22:54       ` Thomas Petazzoni
2016-03-23 12:57         ` Jan Viktorin
2016-03-23 13:06           ` Thomas Petazzoni
2016-03-23 13:10             ` Jan Viktorin
2015-10-20 11:32     ` [Buildroot] [PATCH v2 3/7] altera: improve readme to cover both supported boards Jan Viktorin
2016-03-22 22:54       ` Thomas Petazzoni
2015-10-20 11:32     ` [Buildroot] [PATCH v2 4/7] altera: update text about the mkpimage Jan Viktorin
2016-03-22 22:55       ` Thomas Petazzoni
2015-10-20 11:32     ` [Buildroot] [PATCH v2 5/7] altera: change mmcblk0 to sdc Jan Viktorin
2016-03-22 22:56       ` Thomas Petazzoni
2015-10-20 11:32     ` [Buildroot] [PATCH v2 6/7] altera: improve fdisk instructions Jan Viktorin
2016-03-22 22:58       ` Thomas Petazzoni
2015-10-20 11:32     ` [Buildroot] [PATCH v2 7/7] altera: remove whitespace before colon Jan Viktorin
2016-03-22 23:01       ` Thomas Petazzoni
2015-10-20  5:27 ` [Buildroot] [PATCH] mpkimage: new package Baruch Siach
2015-10-20  7:19 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020091918.79212c0f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox