Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Buildroot support for Intel X1000
Date: Tue, 20 Oct 2015 10:06:56 +0200	[thread overview]
Message-ID: <20151020100656.3d979ad1@free-electrons.com> (raw)
In-Reply-To: <1445252572.4143.12.camel@intel.com>

Ray,

On Mon, 19 Oct 2015 11:02:52 +0000, Kinsella, Ray wrote:
> The Intel X1000 is the Pentium class microprocessor that ships with Galileo
> Gen 1/2. This patch adds changes to arch and toolchain-wrapper to omit the lock
> prefix for the X1000.
> 
> Signed-off-by: Ray Kinsella <ray.kinsella@intel.com>

I've applied your patch, after doing some small tweaks (see below).

> ---
>  arch/Config.in.x86             | 10 ++++++++++
>  toolchain/toolchain-wrapper.c  |  3 +++
>  toolchain/toolchain-wrapper.mk |  4 ++++
>  3 files changed, 17 insertions(+)
> 
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index 43f6abc..28b8adf 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -34,6 +34,14 @@ config BR2_x86_i486
>  config BR2_x86_i586
>  	bool "i586"
>  	depends on !BR2_x86_64
> +config BR2_x86_x1000
> +	bool "x1000"
> +	depends on !BR2_x86_64
> +	help
> +	    The Intel X1000 is a Pentium class microprocessor in the Quark 

Indentation for help text is one tab + two spaces. Also, there was a
trailing space on this line.

> +	    (sub-Atom) Product Line. The X1000 has a bug on the lock prefix
> +	    requiring that prefix must be stripped at build time. See
> +	    https://en.wikipedia.org/wiki/Intel_Quark

And the lines were a bit too long, so I rewrapped them.

> +#ifdef BR_OMIT_LOCK_PREFIX
> +	"-Wa,-momit-lock-prefix=yes", 

There was also a trailing space here.

And finally, I've changed  the commit title to:

	arch/x86: add support for Intel x1000

We indeed like to have some sort of "category" prefix for all patches.
Generally it's just the package name (when the patch is touching a
package), but we also try to do the same for patches touching other
things as well.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-10-20  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 11:02 [Buildroot] [PATCH] Buildroot support for Intel X1000 Kinsella, Ray
2015-10-19 21:48 ` Arnout Vandecappelle
2015-10-20  8:06 ` Thomas Petazzoni [this message]
2015-10-20  9:28   ` Kinsella, Ray
2015-10-20  9:36     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020100656.3d979ad1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox