Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/jsoncpp: broken with musl on x86
Date: Tue, 27 Oct 2015 07:52:07 +0100	[thread overview]
Message-ID: <20151027075207.51f35d1d@free-electrons.com> (raw)
In-Reply-To: <20151021135029.4b4b9e42@free-electrons.com>

Hello,

On Wed, 21 Oct 2015 13:50:29 +0200, Thomas Petazzoni wrote:

> On Tue, 20 Oct 2015 22:51:53 +0200, J?rg Krause wrote:
> > This patch replaces a previous submission made by Bernd Kuhls some while ago
> > [1].
> > 
> > The posix_memalign declaration is incompatible with musl for C++, because of
> > the exception specification [2]. Note, the referenced patch is part of the a
> > patch series to "Add musl support to GCC".
> > 
> > Instead of patching gcc in Buildroot we disable jsoncpp and any reverse
> > dependendy with the musl toolchain on x86.
> > 
> > [1] https://patchwork.ozlabs.org/patch/505425/
> > [2] https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01084.html
> 
> It is indeed not very practical to fix gcc, since external toolchains
> would continue to be affected. But isn't there a way of working around
> the problem inside jsoncpp itself, so that we don't have to do this
> complicated reverse-dependency propagation ?

There is indeed a solution: remove the -pedantic flags from

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall -Wconversion -Wshadow -Wextra -pedantic")

line in CMakeLists.txt. And it builds just fine. It seems a lot simpler
than propagating the reverse dependencies.

Could you submit a patch doing this ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-10-27  6:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 20:51 [Buildroot] [PATCH 1/1] package/jsoncpp: broken with musl on x86 Jörg Krause
2015-10-21 11:50 ` Thomas Petazzoni
2015-10-27  6:52   ` Thomas Petazzoni [this message]
2015-10-27  7:54     ` Jörg Krause
2015-10-27  8:11       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027075207.51f35d1d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox