From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ofono: bump to version 1.17
Date: Sat, 31 Oct 2015 15:55:50 +0100 [thread overview]
Message-ID: <20151031155550.0c2636b8@free-electrons.com> (raw)
In-Reply-To: <1446230985-12935-1-git-send-email-petr.vorel@gmail.com>
Dear Petr Vorel,
On Fri, 30 Oct 2015 19:49:45 +0100, Petr Vorel wrote:
> Updated patch with uClibc support - merge with upstream support
> for musl.
>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> package/ofono/0001-uclibc-backtrace.patch | 55 +++++++++++++++++--------------
> package/ofono/ofono.hash | 2 +-
> package/ofono/ofono.mk | 2 +-
> 3 files changed, 32 insertions(+), 27 deletions(-)
I've applied, thanks!
However, their patch for the musl build is really crappy. Instead, they
should add a configure.ac check for the backtrace related functionality
and use the result of that check instead of testing __GLIBC__. If you
have the courage to improve this and submit it upstream, it would be
good.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-31 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 18:49 [Buildroot] [PATCH 1/1] ofono: bump to version 1.17 Petr Vorel
2015-10-31 14:55 ` Thomas Petazzoni [this message]
2015-10-31 20:45 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151031155550.0c2636b8@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox