Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Remi Pommarel <repk@triplefau.lt>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/git: Add needed library for static compilation
Date: Mon, 2 Nov 2015 09:11:34 +0100	[thread overview]
Message-ID: <20151102081134.GD13534@cruxbox> (raw)
In-Reply-To: <20151102042520.GM3352@tarshish>

Hi baruch,

On Mon, Nov 02, 2015 at 06:25:20AM +0200, Baruch Siach wrote:
> Hi Remi,
> 
> On Sun, Nov 01, 2015 at 09:36:21PM +0100, Remi Pommarel wrote:
> > @@ -57,7 +57,7 @@ endif
> >  
> >  # assume yes for these tests, configure will bail out otherwise
> >  # saying error: cannot run test program while cross compiling
> > -GIT_CONF_ENV = \
> > +GIT_CONF_ENV += \
> >  	ac_cv_fread_reads_directories=yes \
> >  	ac_cv_snprintf_returns_bogus=yes LIBS='$(GIT_CONF_ENV_LIBS)'
> 
> Please move this hunk to patch #3 in this series, which is where it logically 
> belongs.
> 

I removed the gettext part from v1 because it is not needed anymore with
the git patches. But this hunk escapes my attention.

Thanks.
Remi

  reply	other threads:[~2015-11-02  8:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-01 20:36 [Buildroot] [PATCH v2 0/3] package/git: Fix static compilation Remi Pommarel
2015-11-01 20:36 ` [Buildroot] [PATCH v2 1/3] package/git: Add needed library for " Remi Pommarel
2015-11-02  4:25   ` Baruch Siach
2015-11-02  8:11     ` Remi Pommarel [this message]
2015-11-01 20:36 ` [Buildroot] [PATCH v2 2/3] package/git: Add git patch " Remi Pommarel
2015-11-01 20:36 ` [Buildroot] [PATCH v2 3/3] package/git: Used curl-config program for target Remi Pommarel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151102081134.GD13534@cruxbox \
    --to=repk@triplefau.lt \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox