Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] wireshark: fix inet_pton detection
Date: Mon, 2 Nov 2015 21:51:48 +0100	[thread overview]
Message-ID: <20151102215148.1a596cb2@free-electrons.com> (raw)
In-Reply-To: <1446328474-11255-1-git-send-email-ps.report@gmx.net>

Dear Peter Seiderer,

On Sat, 31 Oct 2015 22:54:34 +0100, Peter Seiderer wrote:
> Patch configure.ac to not assume broken inet_pton in case of cross
> compiling (avoids double definition), similare patch is used
> for OpenEmbedded (see [1]).
> 
> Fixes [2]:
> 
>   host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libc.a(ntop.os): In function `inet_pton':
>   ntop.c:(.text+0x4b4): multiple definition of `inet_pton'
>   wsutil/.libs/libwsutil.a(inet_pton.o):inet_pton.c:(.text+0xe0): first defined here
>   collect2: error: ld returned 1 exit status
> 
> [1] http://cgit.openembedded.org/openembedded/tree/recipes/wireshark/files/fix-configure.patch
> [2] http://autobuild.buildroot.net/results/b35/b354ba668ca9476c143f5f7ef1b727b0b5672b04
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  ...o-not-assume-broken-inet_pton-in-case-of-.patch | 32 ++++++++++++++++++++++
>  package/wireshark/wireshark.mk                     |  3 ++
>  2 files changed, 35 insertions(+)
>  create mode 100644 package/wireshark/0001-configure-do-not-assume-broken-inet_pton-in-case-of-.patch

I've applied, but I'm not super happy with the proposed solution
because it's not upstreamable. Can you instead work on a different
patch that adds a autoconf cache variable that allows to override the
result of the "inet_pton is broken" test without patching the
configure.ac ?

See
http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Caching-Results.html
for more details.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-11-02 20:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-31 21:54 [Buildroot] [PATCH v1] wireshark: fix inet_pton detection Peter Seiderer
2015-11-02 20:51 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151102215148.1a596cb2@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox