From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] libuecc: add new package
Date: Wed, 4 Nov 2015 21:48:23 +0100 [thread overview]
Message-ID: <20151104214823.5b2205ba@free-electrons.com> (raw)
In-Reply-To: <1446102782-4565-1-git-send-email-post@lespocky.de>
Dear Alexander Dahl,
On Thu, 29 Oct 2015 08:13:01 +0100, Alexander Dahl wrote:
> This package is a small library used for the Freifunk Gluon project and
> will be used by other upcoming packages. It's my first buildroot package
> and I tried to follow the documentation as close as possible, however as
> you might suppose I'm open for any suggestions.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
> package/Config.in | 1 +
> package/libuecc/Config.in | 6 ++++++
> package/libuecc/libuecc.mk | 13 +++++++++++++
> 3 files changed, 20 insertions(+)
> create mode 100644 package/libuecc/Config.in
> create mode 100644 package/libuecc/libuecc.mk
I've applied your patch, thanks! There were two minor issues:
- The commit log should not contain some "personal" messages such as
"It's my first buildroot package...". The contents of the commit log
is kept forever in the project history. If you want to include such
"personal/contextual" messages, put them either in a separate e-mail
(called the cover letter) or under the --- sign below the
Signed-off-by line.
- There was a line with trailing spaces in Config.in.
Other than that, looked good to, so applied!
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-11-04 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 7:13 [Buildroot] [PATCH 1/2] libuecc: add new package Alexander Dahl
2015-10-29 7:13 ` [Buildroot] [PATCH 2/2] fastd: " Alexander Dahl
2015-11-04 21:21 ` Thomas Petazzoni
2015-11-05 8:31 ` Alexander Dahl
2015-11-04 20:48 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104214823.5b2205ba@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox