Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] python3: add patch to fix PEP 3147 issue with automake built packages
Date: Thu, 5 Nov 2015 00:04:20 +0100	[thread overview]
Message-ID: <20151105000420.5abc2ee1@free-electrons.com> (raw)
In-Reply-To: <20151104225541.15eef643@free-electrons.com>

Hello Christophe,

In fact, it seems that this patch might be causing some Python 3 build
issues. See
http://autobuild.buildroot.org/results/06e/06e7c654a10a7618c0c64c57bfd9f27e770138fc/build-end.log.

Can you have a look?

Thanks!

Thomas

On Wed, 4 Nov 2015 22:55:41 +0100, Thomas Petazzoni wrote:
> Dear Christophe Vu-Brugier,
> 
> On Mon, 31 Aug 2015 14:21:44 +0200, Christophe Vu-Brugier wrote:
> > Packages built with automake use a `py-compile` helper to byte-compile
> > Python source files. This script uses the "py_compile" module from the
> > standard library. In turn, the compile() function in the "py_compile"
> > module invokes the cache_from_source() function provided by importlib.
> > 
> > This commit adds a new patch named "020-importlib-no-pep3147.patch"
> > that changes cache_from_source() and source_from_cache() in importlib
> > to get rid of the "__pycache__" directory.
> > 
> > This commit fixes the following import error in kmod when the module
> > is built for Python 3:
> > 
> >   >>> from kmod import Kmod
> >   Traceback (most recent call last):
> >     File "<stdin>", line 1, in <module>
> >   ImportError: cannot import name 'Kmod'
> > 
> > Moreover, this commit removes two patches that are no longer necessary
> > since modifying cache_from_source() and source_from_cache() disables
> > PEP 3147 for the standard library and distutils / setuptools.
> > 
> >  * 004-old-stdlib-cache.patch
> >  * 016-distutils-no-pep3147.patch
> > 
> > Signed-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>
> > 
> > ---
> > Changes since v1:
> >  * remove patches 004 and 016 as suggested by Thomas Petazzoni
> 
> Applied, thanks.
> 
> Thomas



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-11-04 23:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 12:21 [Buildroot] [PATCH v2] python3: add patch to fix PEP 3147 issue with automake built packages Christophe Vu-Brugier
2015-11-04 21:55 ` Thomas Petazzoni
2015-11-04 23:04   ` Thomas Petazzoni [this message]
2015-11-12 15:31     ` Christophe Vu-Brugier
2015-11-13  7:02       ` Arnout Vandecappelle
2015-11-13 21:45         ` Peter Korsgaard
2015-11-14 16:01           ` Christophe Vu-Brugier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105000420.5abc2ee1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox