From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] wine: Bump to 1.8
Date: Wed, 18 Nov 2015 22:21:11 +0100 [thread overview]
Message-ID: <20151118222111.06e1de92@free-electrons.com> (raw)
In-Reply-To: <564CE703.2070706@dawncrow.de>
Dear Andr? Hentschel,
On Wed, 18 Nov 2015 22:00:51 +0100, Andr? Hentschel wrote:
> In a couple of weeks Wine 1.8 will be released, 1.7.55 was the last 1.7.x version.
> To prepare for the version jump of two years, I want to make sure early if i do something wrong.
> So a quick overlook over the patch would be nice.
> What about moving the patches around like I do? 0003->0001?
> Note that this patches is missing a hash file, will be added back later
The patch looks good to me, there is nothing really complicated in
there. Just a few comments:
* Use 'git format-patch -M' to enable rename detection, so that the
renaming of the patches is detected, and instead of seeing a
complete file being removed, and a complete file being added, we see
a rename.
* In your commit log, please explain what is happening: which patches
are dropped and why, which changes are made to the package other
than bumping the version.
Of course, don't forget your SoB in the commit log as well.
Last suggestion: can you submit the SANE_CONFIG patch upstream, so that
hopefully they merge it before the 1.8 release, and we can have zero
patches for the wine package ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-18 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 21:00 [Buildroot] [RFC] wine: Bump to 1.8 André Hentschel
2015-11-18 21:21 ` Thomas Petazzoni [this message]
2015-11-18 21:46 ` André Hentschel
2015-11-18 21:57 ` Thomas Petazzoni
2015-11-18 22:19 ` André Hentschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118222111.06e1de92@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox