From: Waldemar Brodkorb <wbx@openadk.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] jimtcl: fix compile problem for sparc64
Date: Sat, 21 Nov 2015 10:23:31 +0100 [thread overview]
Message-ID: <20151121092330.GA14832@waldemar-brodkorb.de> (raw)
It is general safe to use -fPIC for all architectures.
-fpic breaks sparc64 compile.
Runtime tested on Qemu ARM, MIPS and SPARC64.
Fixes:
http://autobuild.buildroot.net/results/98f391ad13f22828c022f185c0166daabdb4c1ad/
It also addresses a problem with the wrong symlink for the shared library
recognized while runtime testing.
Signed-off-by: Waldemar Brodkorb <wbx@uclibc-ng.org>
---
package/jimtcl/jimtcl.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
index e79e0f6..79fa742 100644
--- a/package/jimtcl/jimtcl.mk
+++ b/package/jimtcl/jimtcl.mk
@@ -33,8 +33,8 @@ else
JIMTCL_SHARED = --shared
define JIMTCL_INSTALL_LIB
$(INSTALL) -m 0755 -D $(@D)/libjim.so.$(JIMTCL_VERSION) \
- $(1)/usr/lib/libjim.$(JIMTCL_VERSION)
- ln -s libjim.$(JIMTCL_VERSION) $(1)/usr/lib/libjim.so
+ $(1)/usr/lib/libjim.so.$(JIMTCL_VERSION)
+ ln -sf libjim.so.$(JIMTCL_VERSION) $(1)/usr/lib/libjim.so
endef
endif
@@ -47,6 +47,8 @@ define JIMTCL_CONFIGURE_CMDS
endef
define JIMTCL_BUILD_CMDS
+ SH_CFLAGS="-fPIC" \
+ SHOBJ_CFLAGS="-fPIC" \
$(MAKE) -C $(@D)
endef
--
1.7.10.4
next reply other threads:[~2015-11-21 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 9:23 Waldemar Brodkorb [this message]
2015-11-22 13:12 ` [Buildroot] [PATCH] jimtcl: fix compile problem for sparc64 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151121092330.GA14832@waldemar-brodkorb.de \
--to=wbx@openadk.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox