From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] Config.in: add symbols for BR2_HOST_GCC_AT_LEAST_X_Y
Date: Sun, 29 Nov 2015 18:48:05 +0100 [thread overview]
Message-ID: <20151129174805.GC3630@free.fr> (raw)
In-Reply-To: <1448147919-5463-2-git-send-email-arnout@mind.be>
Arnout, All,
On 2015-11-22 00:18 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Some host packages need a recent gcc version. Add symbols to Config.in
> to specify the HOSTCC version. The values are passed through the
> environment, and this environment is generated in a new support script.
I really don't like this...
Maybe it is a good candidate for a generated kconfig snippet, instead of
this generated-environment oddity?
Anyway, see below, you could generate only one environment variable,
instead of all of them...
> Also update the documentation to mention the new symbols.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> Config.in | 17 ++++++++++
> Makefile | 1 +
> docs/manual/adding-packages-directory.txt | 7 ++++
> support/scripts/gcc-version-variables | 56 +++++++++++++++++++++++++++++++
> 4 files changed, 81 insertions(+)
> create mode 100755 support/scripts/gcc-version-variables
>
> diff --git a/Config.in b/Config.in
> index d795361..7bec90c 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -18,6 +18,23 @@ config BR2_EXTERNAL
> string
> option env="BR2_EXTERNAL"
>
> +# Hidden config symbols for packages to check system gcc version
> +config BR2_HOST_GCC_AT_LEAST_4_7
> + bool
> + option env="HOST_GCC_AT_LEAST_4_7"
> +
> +config BR2_HOST_GCC_AT_LEAST_4_8
> + bool
> + option env="HOST_GCC_AT_LEAST_4_8"
> +
> +config BR2_HOST_GCC_AT_LEAST_4_9
> + bool
> + option env="HOST_GCC_AT_LEAST_4_9"
> +
> +config BR2_HOST_GCC_AT_LEAST_5
> + bool
> + option env="HOST_GCC_AT_LEAST_5"
If you make each of those options actually select the N-1 option, then
all you need if to set one environment variable.
[--SNIP--]
> diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> index 139123e..c2d9f75 100644
> --- a/docs/manual/adding-packages-directory.txt
> +++ b/docs/manual/adding-packages-directory.txt
> @@ -283,6 +283,13 @@ use in the comment.
> ** Comment string: +gcc >= X.Y+ and/or `gcc <= X.Y` (replace
> +X.Y+ with the proper version)
>
> +* Host GCC version
> +** Dependency symbol: +BR2_HOST_GCC_AT_LEAST_X_Y+, (replace
> + +X_Y+ with the proper version, see +Config.in+)
> +** Comment string: no comment to be added
> +** Note that it is usually not the package itself that has a minimum
> + host GCC version, but rather a host-package on which it depends.
Well, in case the package builds an internal host tool, and properly
separates BUILD_CC from CC, then the restriction does apply to the
package itself and not a host-package.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-11-29 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 23:18 [Buildroot] [PATCH 1/3] package/Makefile.in: remove HOSTCC_VERSION Arnout Vandecappelle
2015-11-21 23:18 ` [Buildroot] [PATCH 2/3] Config.in: add symbols for BR2_HOST_GCC_AT_LEAST_X_Y Arnout Vandecappelle
2015-11-29 17:48 ` Yann E. MORIN [this message]
2015-11-29 20:55 ` Arnout Vandecappelle
2015-11-29 21:14 ` Yann E. MORIN
2015-11-29 21:41 ` Arnout Vandecappelle
2015-11-29 21:53 ` Yann E. MORIN
2015-11-21 23:18 ` [Buildroot] [PATCH 3/3] nodejs: version 4.X needs host GCC >= 4.8 Arnout Vandecappelle
2015-11-22 19:52 ` [Buildroot] [PATCH 1/3] package/Makefile.in: remove HOSTCC_VERSION Arnout Vandecappelle
2015-11-22 21:43 ` Peter Korsgaard
2015-11-23 19:50 ` Arnout Vandecappelle
2015-11-29 17:52 ` Thomas Petazzoni
2015-11-29 20:39 ` Peter Korsgaard
2015-11-29 20:45 ` Arnout Vandecappelle
2015-11-29 21:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151129174805.GC3630@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox