From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 29 Nov 2015 23:33:38 +0100 Subject: [Buildroot] Missing 'sys/queue.h' on musl In-Reply-To: <565B78D8.6070103@mind.be> References: <20151128184915.6017fae9@free-electrons.com> <20151128192022.6bc8d7fd@free-electrons.com> <20151129092811.0d05dabd@free-electrons.com> <20151129095306.GA3630@free.fr> <565B78D8.6070103@mind.be> Message-ID: <20151129233338.261cf080@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sun, 29 Nov 2015 23:14:48 +0100, Arnout Vandecappelle wrote: > > Adding such a package would be a Buildroot peculiarity, which I would > > prefer we avoid. > > +1 to that. > > Also take into account that we only install it to staging, so there is really > nothing to gain from installing it conditionally. > > The only question is whether to do it in the toolchain virtual package (which > would be unusual to say the least), or duplicate it in the musl and external > toolchain packages. I actually think the latter is the way to go. That's all fine with me. It is a lot better than duplicating sys/queue.h everywhere. It is kind of adding a patch on top of musl that we would have to keep on our side forever, but since it's just a separate header file, there's no maintenance cost, so I think it's fine. Regarding doing it in the toolchain virtual package or duplicate in musl and external toolchain packages, I don't have a strong opinion either way, so if Arnout feels like doing the duplication is better then so be it. Despite the duplication I also believe it is more logical to have it in the musl and external toolchain packages, since doing that in the toolchain virtual package would make that package no longer purely virtual. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com