Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Update the libhttpparser package
Date: Tue, 1 Dec 2015 17:50:59 +0100	[thread overview]
Message-ID: <20151201175059.2c0444b8@free-electrons.com> (raw)
In-Reply-To: <1448972119-12298-1-git-send-email-root@renaud.io>

Renaud,

On Tue, 01 Dec 2015 13:15:19 +0100, Renaud AUBIN wrote:
> The http-parser repository has been transfered from joyent to nodejs.
> Bump version to 2.6.0.
> 
> Signed-off-by: Renaud AUBIN <root@renaud.io>

The commit title for packages should always look like:

	<package>: <description>

So in the case of this commit, it should be:

	libhttpparser: bump to version 2.6.0

Also, when you send a new version of a patch, it should be titled
[PATCHv2] and include a changelog of what has changed since the
previous iteration of the patch. See the Buildroot manual for details
about this, and "git help format-patch" for details on how to do it.

> diff --git a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
> index 29fe04d..df16656 100644
> --- a/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
> +++ b/package/libhttpparser/0001-Use-f-option-when-calling-ln-at-install-time.patch
> @@ -1,4 +1,4 @@
> -From d9dfeca8736318eaad5cd4554cbae059469decde Mon Sep 17 00:00:00 2001
> +From 384917321c45e492b0ca7aaa94d4b15324aef95d Mon Sep 17 00:00:00 2001
>  From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>  Date: Fri, 28 Aug 2015 19:02:11 +0200
>  Subject: [PATCH] Use -f option when calling ln at install time
> @@ -6,29 +6,30 @@ Subject: [PATCH] Use -f option when calling ln at install time
>  This allows "make install; make install" to work properly.

Since you're using libhttpparser, could you submit this patch to the
upstream project, so that we can hopefully get rid of it in the future ?

Finally, if you have some time, could you submit a patch to add a hash
file to this package, since it's fetched from github ?

I've fixed the commit title, and applied to the next branch (soon to be
merged into master).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-12-01 16:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 12:15 [Buildroot] [PATCH 1/1] Update the libhttpparser package Renaud AUBIN
2015-12-01 16:50 ` Thomas Petazzoni [this message]
2015-12-01 21:59   ` Renaud AUBIN
  -- strict thread matches above, loose matches on Subject: below --
2015-12-01  8:35 Renaud AUBIN
2015-12-01 10:10 ` Baruch Siach
2015-12-01 12:21   ` Renaud AUBIN
2015-12-01 20:20     ` Jörg Krause
2015-12-01 20:37       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201175059.2c0444b8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox