From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6] package/unscd: new package
Date: Tue, 1 Dec 2015 22:45:06 +0100 [thread overview]
Message-ID: <20151201224506.6555d6b5@free-electrons.com> (raw)
In-Reply-To: <565E130B.7090201@mind.be>
Dear Arnout Vandecappelle,
On Tue, 1 Dec 2015 22:37:15 +0100, Arnout Vandecappelle wrote:
> > +define UNSCD_EXTRACT_CMDS
> > + cp $(DL_DIR)/$($(PKG)_SOURCE) $(@D)/nscd.c
> > +endef
> > +
> > +define UNSCD_BUILD_CMDS
> > + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) nscd
>
> Although it works because of the default rules, it looks very strange to me to
> call make when there is no Makefile. I would instead call the compiler directly:
>
> cd $(@D); \
> $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) -o nscd nscd.c
>
> What do the others think?
Fully agree with you.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-01 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 15:15 [Buildroot] [PATCH v6] package/unscd: new package Doug Kehn
2015-12-01 21:37 ` Arnout Vandecappelle
2015-12-01 21:45 ` Thomas Petazzoni [this message]
2015-12-02 13:00 ` rdkehn at yahoo.com
2015-12-02 13:20 ` rdkehn at yahoo.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201224506.6555d6b5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox