Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2 for 2015.11.x] package/gawk: do not use readeline ormpfr in host variant
Date: Tue, 1 Dec 2015 23:22:49 +0100	[thread overview]
Message-ID: <20151201232249.57de6d15@free-electrons.com> (raw)
In-Reply-To: <9cd7b6bdd9790d4105829b278c0e6acba9f103f3.1449008170.git.yann.morin.1998@free.fr>

Dear Yann E. MORIN,

Two typos in the commit title.

On Tue,  1 Dec 2015 23:19:07 +0100, Yann E. MORIN wrote:
> gawk has an optional dependency on mpfr (and thus gmp) and readline,
> and will probe for them. If they are present, they are used; if they
> are missing, that's not an error. mpfr (and gmp) is used for "BIGNUM"
> support on gawk; readline is used by the gawk debugger.
> 
> However, mpfr (bringing gmp) are also host-packages in Buildroot, but in
> the standard build order (i.e. a plain 'make'), they are built after
> gawk. Ditto readline (from ncurses).
> 
> If the user has the development files for gmp and mpfr, then gawk is
> linked to them. Ditto readline.
> 
> Now, further on in the build, we build gmp and mpfr (for gcci or guile),
> so we install them in the host dir. Ditto readline (for gdb, ncurses
> itself and a few other packages...)
> 
> But because we forcibly set an RPATH tag on all our host binaries, our
> host gawk will now dynamically link with our versions, when it was in
> fact built against the host ones.
> 
> This did not seem to cause any harm dso far, but is far from ideal.

dso -> so

> 
> Since we do not really need BIGNUM or the debugger in our host gawk, we
> just forcibly disable them and configure gawk without readline or mpfr
> (there's no switch for gmp, but it;s not a direct dependency, it comes

it;s -> it's

> -# We don't have a host-busybox
> +# We don't have a host-busybox, and we don't want to use mpfr

Is the comment really important, especially when it talks about mpfr
but not about readline ?

>  HOST_GAWK_DEPENDENCIES =
>  
> +HOST_GAWK_CONF_OPTS = --without-readline --without-mpfr
> +

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-12-01 22:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 22:19 [Buildroot] [PATCH 0/2 for 2015.11.x] rpath: fix fallout of check-host-rpath (branch yem/host-gawk) Yann E. MORIN
2015-12-01 22:19 ` [Buildroot] [PATCH 1/2 for 2015.11.x] support/check-host-rpath: remove trailing '/' in host dir Yann E. MORIN
2015-12-02 22:40   ` Peter Korsgaard
2015-12-01 22:19 ` [Buildroot] [PATCH 2/2 for 2015.11.x] package/gawk: do not use readeline ormpfr in host variant Yann E. MORIN
2015-12-01 22:22   ` Thomas Petazzoni [this message]
2015-12-02 22:16     ` Yann E. MORIN
2015-12-02 22:34       ` Peter Korsgaard
2015-12-02 22:36         ` Yann E. MORIN
2015-12-02 22:41   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201232249.57de6d15@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox