From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt5/qt53d: new package
Date: Thu, 3 Dec 2015 22:45:59 +0100 [thread overview]
Message-ID: <20151203224559.6ac43924@gmx.net> (raw)
In-Reply-To: <CAAH=mgMQagBAV7+c3+QZFsoOwHOzdAkhmDd3-hPrnr6Cs6KK7w@mail.gmail.com>
Hello Jordon,
On Wed, 2 Dec 2015 12:57:49 +0800, Jordon Wu <jordon.wu@gmail.com> wrote:
> Hi Thomas,
>
> I tested Peter's patch, It didn't handle qt3d's plugins, qml and examples
> cases.
Thanks for testing, short answer to your three critics (longer
answer for details in an upcoming answer to your patch):
- plugins: the only qt3d plugin is in src/plugins/sceneparsers/assimp
and needs the assimp library [1] to build (see the README file for
additional info). The assimp library is (not yet?) available as buildroot
package...
- qml: what do you mean is missing in my patch?
- examples: o.k. missing from my patch, but many examples need the assimp
plugin at run time... I think best would be if you could submit the
example enhancement on top of my patch?
Regards,
Peter
[1] http://assimp.sourceforge.net/
>
> Best Regards
> Jordon Wu
>
> 2015-12-01 20:20 GMT+08:00 Thomas Petazzoni <
> thomas.petazzoni at free-electrons.com>:
>
> > Dear Jordon Wu,
> >
> > On Tue, 1 Dec 2015 14:12:36 +0800, Jordon Wu wrote:
> > > Signed-off-by: Jordon Wu <jordon.wu@gmail.com>
> > > ---
> > > package/qt5/Config.in | 1 +
> > > package/qt5/qt53d/Config.in | 22 ++++++++++++++++
> > > package/qt5/qt53d/qt53d.hash | 4 +++
> > > package/qt5/qt53d/qt53d.mk | 61
> > ++++++++++++++++++++++++++++++++++++++++++++
> > > 4 files changed, 88 insertions(+)
> > > create mode 100755 package/qt5/qt53d/Config.in
> > > create mode 100755 package/qt5/qt53d/qt53d.hash
> > > create mode 100755 package/qt5/qt53d/qt53d.mk
> >
> > For information, we have already a patch pending to add qt5 3d, from
> > Peter Seiderer, which was sent just a few days ago. See:
> > http://patchwork.ozlabs.org/patch/547753/.
> >
> > Maybe you can compare your implementation proposed by Peter (in Cc) and
> > see if there's anything to add to Peter's patch ?
> >
> > Don't hesitate to test Peter's patch and provide your Tested-by if it
> > works for you.
> >
> > Best regards,
> >
> > Thomas
> > --
> > Thomas Petazzoni, CTO, Free Electrons
> > Embedded Linux, Kernel and Android engineering
> > http://free-electrons.com
> >
next prev parent reply other threads:[~2015-12-03 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 6:12 [Buildroot] [PATCH 1/1] qt5/qt53d: new package Jordon Wu
2015-12-01 12:20 ` Thomas Petazzoni
2015-12-02 4:57 ` Jordon Wu
2015-12-03 21:45 ` Peter Seiderer [this message]
2015-12-04 2:29 ` Jordon Wu
2015-12-03 21:54 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203224559.6ac43924@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox