From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Mon, 7 Dec 2015 23:41:56 +0100
Subject: [Buildroot] [PATCH v7 09/33] package/efl/libefl: add webp
 dependency
In-Reply-To: <1449523775-6582-10-git-send-email-romain.naour@openwide.fr>
References: <1449523775-6582-1-git-send-email-romain.naour@openwide.fr>
 <1449523775-6582-10-git-send-email-romain.naour@openwide.fr>
Message-ID: <20151207224156.GF14874@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Romain, All,

On 2015-12-07 22:29 +0100, Romain Naour spake thusly:
> WebP is a new image format that provides lossless and lossy
> compression for images on the web. So enabling webp support
> in efl libraries allow to loads images using WebP.
> 
> Also, it one of the "highly recommended" dependecies [1]
> according to the README but disabling it doesn't need
> the --enable-i-really-know-what-i-am-doing... option.
> That's why BR2_PACKAGE_LIBEFL_WEBP is not added to
> BR2_PACKAGE_LIBEFL_RECOMMENDED_CONFIG.
> 
> [1] https://git.enlightenment.org/core/efl.git/tree/README?id=v1.15.2#n486
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v6: select BR2_PACKAGE_WEBP (Yann E.Morin)
> v4: rename to libefl
>     improve commit log
> ---
>  package/efl/libefl/Config.in | 6 ++++++
>  package/efl/libefl/libefl.mk | 9 +++++++--
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/package/efl/libefl/Config.in b/package/efl/libefl/Config.in
> index 3cf4b4e..0b89411 100644
> --- a/package/efl/libefl/Config.in
> +++ b/package/efl/libefl/Config.in
> @@ -112,4 +112,10 @@ config BR2_PACKAGE_LIBEFL_TIFF
>  	help
>  	  This enables the loader code that loads tiff files.
>  
> +config BR2_PACKAGE_LIBEFL_WEBP
> +	bool "libevas webp image loader"
> +	select BR2_PACKAGE_WEBP
> +	help
> +	  This enables the loader code that loads images using WebP.
> +
>  endif # BR2_PACKAGE_LIBEFL
> diff --git a/package/efl/libefl/libefl.mk b/package/efl/libefl/libefl.mk
> index 10d0a98..e479cfc 100644
> --- a/package/efl/libefl/libefl.mk
> +++ b/package/efl/libefl/libefl.mk
> @@ -32,7 +32,6 @@ LIBEFL_GETTEXTIZE = YES
>  # --disable-cxx-bindings: disable C++11 bindings.
>  # --disable-fb: disable frame buffer support.
>  # --disable-image-loader-jp2k: disable JPEG 2000 support.
> -# --disable-image-loader-webp: disable webp support.
>  # --disable-sdl: disable sdl2 support.
>  # --disable-systemd: disable systemd support.
>  # --disable-xinput22: disable X11 XInput v2.2+ support.
> @@ -45,7 +44,6 @@ LIBEFL_CONF_OPTS = \
>  	--disable-cxx-bindings \
>  	--disable-fb \
>  	--disable-image-loader-jp2k \
> -	--disable-image-loader-webp \
>  	--disable-sdl \
>  	--disable-systemd \
>  	--enable-lua-old \
> @@ -177,6 +175,13 @@ else
>  LIBEFL_CONF_OPTS += --disable-image-loader-tiff
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBEFL_WEBP),y)
> +LIBEFL_CONF_OPTS += --enable-image-loader-webp=yes
> +LIBEFL_DEPENDENCIES += webp
> +else
> +LIBEFL_CONF_OPTS += --disable-image-loader-webp
> +endif
> +
>  $(eval $(autotools-package))
>  
>  ################################################################################
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'