Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 23/33] package/efl/libethumb: remove package
Date: Tue, 8 Dec 2015 12:18:31 +0100	[thread overview]
Message-ID: <20151208111831.GJ4188@free.fr> (raw)
In-Reply-To: <1449523775-6582-24-git-send-email-romain.naour@openwide.fr>

Romain, All,

On 2015-12-07 22:29 +0100, Romain Naour spake thusly:
> Libethumb is now available in efl package.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> v6: Improve lecacy help text (Yann E.Morin)
> v4: remove libethumb from package/efl/
> v3: update legacy option for 2015.11
>     update help text
> ---
>  Config.in.legacy                   |  7 +++++++
>  package/efl/Config.in              |  1 -
>  package/efl/libethumb/Config.in    | 15 ---------------
>  package/efl/libethumb/libethumb.mk | 27 ---------------------------

You forgot to remove the patch that was added by Peter in a36d751 after
you initially did your series, and after I provided my review.

Remove the patch, and my review stands. ;-)

Regards,
Yann E. MORIN.

>  4 files changed, 7 insertions(+), 43 deletions(-)
>  delete mode 100644 package/efl/libethumb/Config.in
>  delete mode 100644 package/efl/libethumb/libethumb.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 2bbf2ed..92dc3ac 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -107,6 +107,13 @@ endif
>  ###############################################################################
>  comment "Legacy options removed in 2016.02"
>  
> +config BR2_PACKAGE_LIBETHUMB
> +	bool "libethumb package has been removed"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_EFL
> +	help
> +	  With EFL 1.15, libethumb is now provided by the libefl package.
> +
>  config BR2_PACKAGE_INFOZIP
>  	bool "infozip option has been renamed to zip"
>  	select BR2_LEGACY
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> index 1c6f9e5..ff8ba83 100644
> --- a/package/efl/Config.in
> +++ b/package/efl/Config.in
> @@ -24,7 +24,6 @@ source "package/efl/libeio/Config.in"
>  source "package/efl/libevas/Config.in"
>  source "package/efl/libembryo/Config.in"
>  source "package/efl/libedje/Config.in"
> -source "package/efl/libethumb/Config.in"
>  source "package/efl/libelementary/Config.in"
>  source "package/efl/libedbus/Config.in"
>  
> diff --git a/package/efl/libethumb/Config.in b/package/efl/libethumb/Config.in
> deleted file mode 100644
> index 3e9cbde..0000000
> --- a/package/efl/libethumb/Config.in
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -comment "libethumb needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -
> -config BR2_PACKAGE_LIBETHUMB
> -	bool "libethumb"
> -	select BR2_PACKAGE_LIBEINA
> -	select BR2_PACKAGE_LIBEVAS
> -	select BR2_PACKAGE_LIBECORE
> -	select BR2_PACKAGE_LIBECORE_EVAS
> -	select BR2_PACKAGE_LIBEDJE
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # libevas
> -	help
> -	  Ethumb is a library for generating thumbnail images of documents.
> -
> -	  http://trac.enlightenment.org/e/wiki/Ethumb
> diff --git a/package/efl/libethumb/libethumb.mk b/package/efl/libethumb/libethumb.mk
> deleted file mode 100644
> index 314ddf9..0000000
> --- a/package/efl/libethumb/libethumb.mk
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -################################################################################
> -#
> -# libethumb
> -#
> -################################################################################
> -
> -LIBETHUMB_VERSION = 1.7.10
> -LIBETHUMB_SOURCE = ethumb-$(LIBETHUMB_VERSION).tar.bz2
> -LIBETHUMB_SITE = http://download.enlightenment.org/releases
> -LIBETHUMB_LICENSE = LGPLv2.1+
> -LIBETHUMB_LICENSE_FILES = COPYING
> -
> -LIBETHUMB_INSTALL_STAGING = YES
> -
> -LIBETHUMB_DEPENDENCIES = libeina libevas libecore libedje host-libedje
> -
> -LIBETHUMB_CONF_OPTS = --with-edje-cc=$(HOST_DIR)/usr/bin/edje_cc
> -
> -ifeq ($(BR2_PACKAGE_LIBEXIF),y)
> -LIBETHUMB_DEPENDENCIES += libexif
> -endif
> -
> -ifeq ($(BR2_PACKAGE_LIBEDBUS),y)
> -LIBETHUMB_DEPENDENCIES += libedbus
> -endif
> -
> -$(eval $(autotools-package))
> -- 
> 2.4.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-12-08 11:18 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 21:29 [Buildroot] [PATCH v7 00/33] efl bump to 1.15.2 Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 01/33] package/expedite: move to package directory Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 02/33] package/libevas-generic-loaders: " Romain Naour
2015-12-07 21:41   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 03/33] package/libevas-generic-loaders: svg loader: add MMU dependency Romain Naour
2015-12-07 21:45   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 04/33] package/{efl packages}: reorder select/depends Romain Naour
2015-12-07 21:58   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 05/33] package/efl/libefl: new host-package Romain Naour
2015-12-07 22:17   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 06/33] package/efl/libefl: new package Romain Naour
2015-12-07 22:41   ` Yann E. MORIN
2015-12-08 10:47   ` Yann E. MORIN
2015-12-08 21:43     ` Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 07/33] package/efl/libefl: add harfbuzz dependency Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 08/33] package/efl/libefl: add wayland dependency Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 09/33] package/efl/libefl: add webp dependency Romain Naour
2015-12-07 22:41   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 10/33] package/efl/libefl: add frame buffer config option Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 11/33] package/efl/libefl: add jp2k " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 12/33] package/efl/libefl: add X11 support Romain Naour
2015-12-08 10:28   ` Yann E. MORIN
2015-12-08 10:58   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 13/33] package/efl/libefl: add OpenGL/OpenGLES support Romain Naour
2015-12-08 10:35   ` Yann E. MORIN
2015-12-08 12:46   ` Yann E. MORIN
2015-12-08 21:15     ` Yann E. MORIN
2015-12-09 22:52     ` Romain Naour
2015-12-09 22:57       ` Yann E. MORIN
2015-12-10 18:15         ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 14/33] package/efl/libefl: enable xinput2.2 Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 15/33] package/efl/libefl: add systemd dependency Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 16/33] package/libevas-generic-loaders: bump to version 1.15.0 Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 17/33] package/libevas-generic-loaders: add libraw dependency Romain Naour
2015-12-08 11:00   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 18/33] package/efl/libelementary: bump to version 1.15.2 Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 19/33] package/efl: libefl and libelementary share the same version number Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 20/33] package/enlightenment: bump to version 0.19.12 Romain Naour
2015-12-08 11:06   ` Yann E. MORIN
2015-12-09 22:34     ` Romain Naour
2015-12-09 22:39       ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 21/33] package/expedite: bump to efl-1.15 branch Romain Naour
2015-12-08 11:09   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 22/33] package/dbus-cpp: switch to libefl Romain Naour
2015-12-08 11:10   ` Yann E. MORIN
2015-12-07 21:29 ` [Buildroot] [PATCH v7 23/33] package/efl/libethumb: remove package Romain Naour
2015-12-08 11:18   ` Yann E. MORIN [this message]
2015-12-07 21:29 ` [Buildroot] [PATCH v7 24/33] package/efl/libedje: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 25/33] package/efl/libembryo: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 26/33] package/efl/libeio: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 27/33] package/efl/libefreet: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 28/33] package/efl/libedbus: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 29/33] package/efl/libecore: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 30/33] package/efl/libevas: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 31/33] package/efl/libeet: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 32/33] package/efl/libeina: " Romain Naour
2015-12-07 21:29 ` [Buildroot] [PATCH v7 33/33] package/libemotion-generic-players: new package Romain Naour
2015-12-08 14:27   ` Yann E. MORIN
2015-12-08 15:25     ` Yann E. MORIN
2015-12-08 22:50     ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208111831.GJ4188@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox