From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr
Date: Tue, 8 Dec 2015 21:59:10 +0100 [thread overview]
Message-ID: <20151208205910.GW4188@free.fr> (raw)
In-Reply-To: <1449174328-8317-1-git-send-email-sergio.prado@e-labworks.com>
Sergio, All,
Thanks for your patch! :-)
On 2015-12-03 18:25 -0200, Sergio Prado spake thusly:
> Disable ustr inline functions to avoid multiple definition of symbols error
> when linking with ustr.
>
> Fixes:
> http://autobuild.buildroot.net/results/e7012c7a734dbdd1c697cf63b6df6e834e8eafc7
> http://autobuild.buildroot.net/results/0783a63e4694ffa8463ef5533b635c7e7c43dd42
> http://autobuild.buildroot.net/results/40726abf3419a727c5762ef2791dbf53fa1736c0
> http://autobuild.buildroot.net/results/a6a0c827c393a5fb41653d71d1ee50df283a32fb
> ...
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
As Thomas already pointed to, there is already a two-patch series to fix
the issue by bumping and fixing ustr itself.
So I've marked your patch as rejected in our patchwork:
https://patchwork.ozlabs.org/patch/552445/
Thanks! :-)
Regards,
Yann E. MORIN.
> ---
> package/libsemanage/libsemanage.mk | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/libsemanage/libsemanage.mk b/package/libsemanage/libsemanage.mk
> index 197c14e4229a..ea9f4c9f67de 100644
> --- a/package/libsemanage/libsemanage.mk
> +++ b/package/libsemanage/libsemanage.mk
> @@ -13,10 +13,15 @@ LIBSEMANAGE_INSTALL_STAGING = YES
>
> LIBSEMANAGE_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS)
>
> +# disable ustr inline functions to avoid multiple definition of symbols
> +# error when linking
> +LIBSEMANAGE_CFLAGS = $(TARGET_CFLAGS) -DUSTR_CONF_COMPILE_USE_INLINE=0
> +
> define LIBSEMANAGE_BUILD_CMDS
> # DESTDIR is needed during the compile to compute library and
> # header paths.
> - $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) DESTDIR=$(STAGING_DIR) all
> + $(MAKE) -C $(@D) $(LIBSEMANAGE_MAKE_OPTS) CFLAGS="$(LIBSEMANAGE_CFLAGS)" \
> + DESTDIR=$(STAGING_DIR) all
> endef
>
> define LIBSEMANAGE_INSTALL_STAGING_CMDS
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-12-08 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 20:25 [Buildroot] [PATCH] libsemanage: fix build error when linking with ustr Sergio Prado
2015-12-03 21:07 ` Thomas Petazzoni
2015-12-08 20:59 ` Yann E. MORIN [this message]
2015-12-09 0:59 ` Sergio Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208205910.GW4188@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox