From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libass: Fix fontconfig detection
Date: Sun, 13 Dec 2015 18:34:43 +0100 [thread overview]
Message-ID: <20151213173443.GF3679@free.fr> (raw)
In-Reply-To: <1450025851-2594-1-git-send-email-bernd.kuhls@t-online.de>
Bernd, all,
On 2015-12-13 17:57 +0100, Bernd Kuhls spake thusly:
> This patch is a combination of the approaches by Vicente and Yann
> discussed in http://patchwork.ozlabs.org/patch/553448/ to fix the
> configure bug due to fontconfig being disabled.
Thanks for your patch! :-)
however, see my comments, below...
> Fixes
> http://autobuild.buildroot.net/results/923/923e8688ab6a294b51fa146cd2ed23db20fe7341/
> and many others
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libass/libass.mk | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/package/libass/libass.mk b/package/libass/libass.mk
> index 83939e2..72770e2 100644
> --- a/package/libass/libass.mk
> +++ b/package/libass/libass.mk
> @@ -24,6 +24,15 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
> LIBASS_DEPENDENCIES += host-yasm
> endif
>
> +# libass uses the concept of a "system font provider", in the linux case
> +# this is currently only fontconfig. If fontconfig is disabled we need
> +# the following configure option to avoid a configure error. This option
> +# can be appended in the future when other linux packages are taking care
> +# of the role as "system font provider".
> +ifneq ($(BR2_PACKAGE_FONTCONFIG),y)
> +LIBASS_CONF_OPTS = --disable-require-system-font-provider
> +endif
Again, I'm not too happy with this. We already have a fontconfig
conditional block, below. So this code should go strainght in the else
clause.
Then, when/if (and *only* then) libass gains support for another system
font provider, we can think of changing it.
At worse, I'd prefer Vicente's solution.
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> LIBASS_DEPENDENCIES += fontconfig
> LIBASS_CONF_OPTS += --enable-fontconfig
> --
> 2.6.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2015-12-13 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 16:57 [Buildroot] [PATCH 1/1] package/libass: Fix fontconfig detection Bernd Kuhls
2015-12-13 17:34 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151213173443.GF3679@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox