From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/4] package/lttng-tools: use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS dependency
Date: Sun, 13 Dec 2015 21:15:27 +0100 [thread overview]
Message-ID: <20151213201527.GD27971@free.fr> (raw)
In-Reply-To: <1450032471-3405-3-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2015-12-13 19:47 +0100, Samuel Martin spake thusly:
> Using this newly introduced symbol lets to simplify the dependency code.
>
> This change also adds the missing architecture dependencies on the second
> comment.
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> changes v1-> v2:
> - new patch
> ---
> package/lttng-tools/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/lttng-tools/Config.in b/package/lttng-tools/Config.in
> index 4c5b5f6..599095d 100644
> --- a/package/lttng-tools/Config.in
> +++ b/package/lttng-tools/Config.in
> @@ -6,7 +6,7 @@ config BR2_PACKAGE_LTTNG_TOOLS
> select BR2_PACKAGE_UTIL_LINUX
> select BR2_PACKAGE_UTIL_LINUX_LIBUUID
> # liburcu only works on some architectures and requires thread support
> - depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
> + depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
> depends on BR2_USE_WCHAR # util-linux
> @@ -30,10 +30,11 @@ config BR2_PACKAGE_LTTNG_TOOLS
> http://lttng.org
>
> comment "lttng-tools needs a toolchain w/ threads, wchar"
> - depends on BR2_arm || BR2_armeb || BR2_aarch64 || BR2_i386 || BR2_powerpc || BR2_x86_64
> + depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58595 # lttng-tools/gcc-4.{7,8}.x bug
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_58854 # liburcu/gcc-4.8.x bug
>
> comment "lttng-tools needs a toolchain not affected by GCC bug 58854 and 58595"
> + depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_HAS_GCC_BUG_58854 || BR2_TOOLCHAIN_HAS_GCC_BUG_58595
> --
> 2.6.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-12-13 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 18:47 [Buildroot] [PATCH v2 1/4] package/liburcu: introduce BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS symbol Samuel Martin
2015-12-13 18:47 ` [Buildroot] [PATCH v2 2/4] package/lttng-libust: use BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS dependency Samuel Martin
2015-12-13 20:09 ` Yann E. MORIN
2015-12-13 18:47 ` [Buildroot] [PATCH v2 3/4] package/lttng-tools: " Samuel Martin
2015-12-13 20:15 ` Yann E. MORIN [this message]
2015-12-13 18:47 ` [Buildroot] [PATCH v2 4/4] package/netsniff: fix missing depend on statements Samuel Martin
2015-12-13 20:16 ` Yann E. MORIN
2015-12-13 20:05 ` [Buildroot] [PATCH v2 1/4] package/liburcu: introduce BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS symbol Yann E. MORIN
2015-12-13 21:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151213201527.GD27971@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox