From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 13 Dec 2015 23:01:45 +0100 Subject: [Buildroot] [PATCH] openvmtools: enable for uClibc toolchains In-Reply-To: <20151204165330.GA5268@waldemar-brodkorb.de> References: <20151204165330.GA5268@waldemar-brodkorb.de> Message-ID: <20151213230145.765dd4a1@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Waldemar Brodkorb, On Fri, 4 Dec 2015 17:53:30 +0100, Waldemar Brodkorb wrote: > Since uClibc-ng 1.0.9 openvmtools can be compiled as > the missing euidaccess function was added. > > Signed-off-by: Waldemar Brodkorb > --- > package/openvmtools/Config.in | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Arnout explained very well that this patch is not super great due to the need to keep things working with older uClibc toolchains. Could you instead cook a patch that changes openvmtools to detect if euidaccess() is available or not. If it is available, then it uses it, otherwise, it open-codes it (the euidaccess implementation in uClibc is just one line, so it's not a big deal to copy that in the openvmtools source code). Are you willing to implement such a solution? I'd say that within 6/12 months, we should be able to kill non-ng uClibc support. Blackfin will be a problem... but Blackfin has always been a problem. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com