From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: Build and install kernel selftests
Date: Tue, 15 Dec 2015 18:31:17 +0100 [thread overview]
Message-ID: <20151215173117.GA3596@free.fr> (raw)
In-Reply-To: <20151215063752.GK2318@tarshish>
Baruch, Cyril, All,
On 2015-12-15 08:37 +0200, Baruch Siach spake thusly:
> On Mon, Dec 14, 2015 at 11:18:46PM +0100, Yann E. MORIN wrote:
> > On 2015-11-25 10:53 +1100, Cyril Bur spake thusly:
> > > +config BR2_LINUX_KERNEL_TOOL_SELFTESTS
> > > + bool "selftests"
> >
> > Since the .mk has:
> > SELFTESTS_DEPENDENCIES = bash
> >
> > then you must either depend on bash or select it here. I think a select
> > is better, so:
> >
> > depends on BR2_USE_MMU # bash
> > select BR2_PACKAGE_BASH
>
> But BR2_PACKAGE_BASH depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS.
Gah... I missed that... Thanks for spotting! :-)
> Should
> BR2_LINUX_KERNEL_TOOL_SELFTESTS also depend on
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS?
Yes. With a comment stating so, like:
config BR2_LINUX_KERNEL_TOOL_SELFTESTS
bool "selftests"
depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
depends on BR2_USE_MMU # bash
select BR2_PACKAGE_BASH
comment "selftests needs BR2_PACKAGE_BUSYBOX_SHOW_OTHERS"
depends on !BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
(not so nice, but we already have it for openvmtools.)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-12-15 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 23:53 [Buildroot] [PATCH] Add Linux kernel selftests building Cyril Bur
2015-11-24 23:53 ` [Buildroot] [PATCH] linux: Build and install kernel selftests Cyril Bur
2015-12-14 22:18 ` Yann E. MORIN
2015-12-15 6:37 ` Baruch Siach
2015-12-15 17:31 ` Yann E. MORIN [this message]
2015-12-17 1:25 ` Cyril Bur
2015-12-17 1:45 ` Cyril Bur
2015-12-17 18:07 ` Yann E. MORIN
2015-12-21 5:44 ` Cyril Bur
2015-12-21 9:25 ` Yann E. MORIN
2015-12-21 22:18 ` Cyril Bur
2015-12-21 22:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215173117.GA3596@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox