From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] nfs-utils: install /etc/nfsmount.conf
Date: Mon, 21 Dec 2015 16:16:58 +0100 [thread overview]
Message-ID: <20151221161658.0aaf830d@free-electrons.com> (raw)
In-Reply-To: <1450707537-30154-2-git-send-email-yba@tkos.co.il>
Dear Jonathan Ben-Avraham,
On Mon, 21 Dec 2015 16:18:56 +0200, Jonathan Ben-Avraham wrote:
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 30f12fd..55b75e2 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -38,6 +38,9 @@ endif
> define NFS_UTILS_INSTALL_FIXUP
> rm -f $(NFS_UTILS_TARGETS_)
> touch $(TARGET_DIR)/etc/exports
> + $(INSTALL) -m 744 \
Why 744 and not 644 ? It doesn't make much sense to have an executable
configuration file.
Also, please use the -D option.
> + $(BUILD_DIR)/nfs-utils-$(NFS_UTILS_VERSION)/utils/mount/nfsmount.conf \
Please use:
$(@D)/utils/mount/nfsmount.conf
> + $(TARGET_DIR)/etc
And a full destination path here:
$(TARGET_DIR)/etc/nfsmount.conf
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-21 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 14:18 [Buildroot] [PATCH 1/1 v1] new package: autofs Jonathan Ben-Avraham
2015-12-21 14:18 ` [Buildroot] [PATCH 1/1] nfs-utils: install /etc/nfsmount.conf Jonathan Ben-Avraham
2015-12-21 15:16 ` Thomas Petazzoni [this message]
2015-12-22 17:13 ` Jonathan Ben Avraham
2015-12-21 14:18 ` [Buildroot] [PATCH 1/1] new packages: yp-tools, ypbind-mt Jonathan Ben-Avraham
2015-12-21 15:58 ` Thomas Petazzoni
2015-12-22 17:26 ` Jonathan Ben Avraham
2015-12-21 15:15 ` [Buildroot] [PATCH 1/1 v1] new package: autofs Thomas Petazzoni
2015-12-22 16:55 ` Jonathan Ben Avraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221161658.0aaf830d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox