From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] emlog: new package
Date: Mon, 21 Dec 2015 23:52:23 +0100 [thread overview]
Message-ID: <20151221235223.5bed5c79@free-electrons.com> (raw)
In-Reply-To: <1450446298-3523-1-git-send-email-joris.lijssens@gmail.com>
Joris,
On Fri, 18 Dec 2015 14:44:58 +0100, Joris Lijssens wrote:
> diff --git a/package/emlog/Config.in b/package/emlog/Config.in
> new file mode 100644
> index 0000000..85a9ed6
> --- /dev/null
> +++ b/package/emlog/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_EMLOG
> + bool "emlog"
> + help
> + emlog is a Linux kernel module that makes it easy to access the most
> + recent (and only the most recent) output from a process. It works
> + just like "tail -f" on a log file, except that the storage required
> + never grows. This can be useful in embedded systems where there isn't
> + enough memory or disk space for keeping complete log files, but the
> + most recent debugging messages are sometimes needed (e.g., after an
> + error is observed).
> +
> + https://github.com/nicupavel/emlog
I did not spot this during the previous review, and Arnout also didn't
spot it apparently, so maybe I'm missing something.
emlog is a kernel module, so surely it needs the Linux kernel to be
built beforehand. So your package should "depends on BR2_LINUX_KERNEL"
and have "linux" in EMLOG_DEPENDENCIES. Otherwise, I don't see how it
can even build.
Could you look into this, as well as the comments from Arnout, and
resend an updated version of your patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-21 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 13:44 [Buildroot] [PATCH 1/1] emlog: new package Joris Lijssens
2015-12-18 16:07 ` Thomas Petazzoni
2015-12-20 16:06 ` Arnout Vandecappelle
2015-12-21 22:52 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-04 10:22 [Buildroot] [PATCH 1/1] emlog:new package Joris Lijssens
2015-12-17 21:42 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151221235223.5bed5c79@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox