Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openbox: new package
Date: Tue, 22 Dec 2015 11:01:29 +0100	[thread overview]
Message-ID: <20151222110129.467c78a0@free-electrons.com> (raw)
In-Reply-To: <1448897458-28332-1-git-send-email-ezequiel@vanguardiasur.com.ar>

Ezequiel,

On Mon, 30 Nov 2015 12:30:58 -0300, Ezequiel Garcia wrote:
> Add support for the Openbox Windows Manager.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> Openbox was submitted long ago to Buildroot but it never got accepted:

I've applied your patch, but after doing a few substantial changes:

    [Thomas:
      - don't mention MMU in the Config.in comment.
      - wchar was forgotten in the Config.in comment.
      - the dependency of the comment on thread should be "depends on
        !BR2_TOOLCHAIN_HAS_THREADS" so that the comment is shown when
        thread support is *not* available.
      - add missing select of BR2_PACKAGE_XLIB_LIBXFT and
        BR2_PACKAGE_XLIB_LIBXRENDER which are needed for pango to have xft
        support, otherwise the build fails with "configure: error: Package
        requirements (pango >= 1.8.0 pangoxft >= 1.8.0) were not met:"
      - remove useless empty newline in the hash file
      - add missing dependency on host-pkgconf, which is needed since
        the configure.ac uses PKG_CHECK_MODULES.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-12-22 10:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 15:30 [Buildroot] [PATCH] openbox: new package Ezequiel Garcia
2015-12-21 21:58 ` Ezequiel Garcia
2015-12-22 10:01 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222110129.467c78a0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox