[Buildroot] [PATCH 2/2] Fixing xdriver_xf86-video-ati dependencies

[Yann E. MORIN <yann.morin.1998@free.fr>]

Lada, All,

On 2015-12-22 16:29 +0300, Lada Trimasova spake thusly:
> This package depends on the radeon driver from libdrm and depends on 
> DRI support in xserver_xorg-server, to achieve this we select the 
> Radeon mesa3d DRI driver.
> 
> Fixes:
> http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035
> 
> Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/x11r7/xdriver_xf86-video-ati/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/x11r7/xdriver_xf86-video-ati/Config.in b/package/x11r7/xdriver_xf86-video-ati/Config.in
> index 191c20f..ef96366 100644
> --- a/package/x11r7/xdriver_xf86-video-ati/Config.in
> +++ b/package/x11r7/xdriver_xf86-video-ati/Config.in
> @@ -1,8 +1,8 @@
>  config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
>  	bool "xf86-video-ati"
>  	depends on BR2_PACKAGE_MESA3D
> -	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> -	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> +	select BR2_PACKAGE_LIBDRM
> +	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON        

You ar eremoving the 'select' on BR2_PACKAGE_LIBDRM_RADEON. This is OK
with the current code, because BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON does
the 'select' too.

However, does xdriver_xf86-video-ati link with libdrm_radeon directly?
If so, and the build failure you linked to above seems to imply it does,
then you should keep the 'select' here, because it is a direct
dependency.

Otherwise, I'm Ok with the change.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
>  	select BR2_PACKAGE_XPROTO_FONTSPROTO
>  	select BR2_PACKAGE_XPROTO_GLPROTO
> -- 
> 2.5.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'