Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] Fixing xdriver_xf86-video-ati dependencies
Date: Wed, 23 Dec 2015 19:31:33 +0100	[thread overview]
Message-ID: <20151223183133.GD3426@free.fr> (raw)
In-Reply-To: <1450874992-15627-3-git-send-email-ltrimas@synopsys.com>

Lada, All,

On 2015-12-23 15:49 +0300, Lada Trimasova spake thusly:
> This package depends on the radeon driver from libdrm and depends on
> DRI support in xserver_xorg-server, to achieve this we select the
> Radeon mesa3d DRI driver.
> 
> Fixes:
> http://autobuild.buildroot.net/results/9da/9da4ffdf1c4ec78ae37322e253cb769340116035
> 
> Signed-off-by: Lada Trimasova <ltrimas@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/x11r7/xdriver_xf86-video-ati/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/x11r7/xdriver_xf86-video-ati/Config.in b/package/x11r7/xdriver_xf86-video-ati/Config.in
> index 191c20f..00d91bd 100644
> --- a/package/x11r7/xdriver_xf86-video-ati/Config.in
> +++ b/package/x11r7/xdriver_xf86-video-ati/Config.in
> @@ -1,8 +1,9 @@
>  config BR2_PACKAGE_XDRIVER_XF86_VIDEO_ATI
>  	bool "xf86-video-ati"
>  	depends on BR2_PACKAGE_MESA3D
> -	select BR2_PACKAGE_LIBDRM        if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> -	select BR2_PACKAGE_LIBDRM_RADEON if BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> +	select BR2_PACKAGE_LIBDRM
> +	select BR2_PACKAGE_LIBDRM_RADEON
> +	select BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON

Sorry that I missed it in my previous reply, but you select libdrm, so
you need to propagate its dependencies, too:

    depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm -> libpthread-stubs

This dependency is currently not a problem, because mesa3d hasa stricter
dependency on NPTL, but you still have to propagate the dependencies of
the packages you select.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_XLIB_LIBXCOMPOSITE
>  	select BR2_PACKAGE_XPROTO_FONTSPROTO
>  	select BR2_PACKAGE_XPROTO_GLPROTO
> -- 
> 2.5.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-12-23 18:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 12:49 [Buildroot] [PATCH v2 0/2] Fixing xdriver_xf86-video-ati building Lada Trimasova
2015-12-23 12:49 ` [Buildroot] [PATCH v2 1/2] Enabling mesa3d radeon driver for all architectures Lada Trimasova
2015-12-23 18:27   ` Yann E. MORIN
2015-12-23 22:01   ` Thomas Petazzoni
2015-12-23 12:49 ` [Buildroot] [PATCH v2 2/2] Fixing xdriver_xf86-video-ati dependencies Lada Trimasova
2015-12-23 18:31   ` Yann E. MORIN [this message]
2015-12-24 13:55     ` Lada Trimasova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223183133.GD3426@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox