Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support
Date: Wed, 23 Dec 2015 23:10:24 +0100	[thread overview]
Message-ID: <20151223231024.3c760e7b@free-electrons.com> (raw)
In-Reply-To: <20151128143030.GA3816@free.fr>

Yann,

Sergi sent a v2 of his patch... but your suggestion doesn't work. See
below.

On Sat, 28 Nov 2015 15:30:30 +0100, Yann E. MORIN wrote:

> I wonder if we should not make VFP optional, and change the CPU nme on
> whether the user has enabled VFP, like:
> 
>     config BR2_arm11mpcore
>         bool "mpcore"
>         [...]
>         select BR2_ARM_CPU_MAYBE_HAS_VFPV2
>         [...]
> 
>     config BR2_GCC_TARGET_CPU
>         [...]
>         default "mpcore"        if BR2_arm11mpcore && BR2_ARM_CPU_HAS_VFPV2
>         default "mpcorenovfp"   if BR2_arm11mpcore
>         [...]

This doesn't work, because BR2_ARM_CPU_HAS_VFPV2 is not a user visible
option, and there is nothing that selects it in the current Buildroot.
Therefore the "mpcore" case can never be reached.

Consequently, I am tempted to take v1 of Sergi's patch. Yes, it means
we don't support the no-VFP variant of ARM11 MPCore, but I'm not sure
there are lots of ARM11 MPCore without a VFP, so maybe supporting
mpcorenovfp is not worth the effort for the moment.

Thoughts?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-12-23 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28  9:59 [Buildroot] [PATCH 1/1] Add ARM11 MPCore CPU target support Sergi Granell
2015-11-28 14:30 ` Yann E. MORIN
2015-12-23 22:10   ` Thomas Petazzoni [this message]
2015-12-27 17:04     ` Yann E. MORIN
2015-12-27 17:50       ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2015-11-28 14:55 Sergi Granell
2015-12-27 19:58 ` Yann E. MORIN
2016-01-03 21:39   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223231024.3c760e7b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox