Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/3] doom-wad: bump to version 1.9
Date: Wed, 23 Dec 2015 23:37:18 +0100	[thread overview]
Message-ID: <20151223233718.2703675c@free-electrons.com> (raw)
In-Reply-To: <1446839279-9021-2-git-send-email-rprebello@gmail.com>

Dear Rodrigo Rebello,

On Fri,  6 Nov 2015 17:47:58 -0200, Rodrigo Rebello wrote:

> diff --git a/package/doom-wad/doom-wad.hash b/package/doom-wad/doom-wad.hash
> new file mode 100644
> index 0000000..fa069c1
> --- /dev/null
> +++ b/package/doom-wad/doom-wad.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256	cacf0142b31ca1af00796b4a0339e07992ac5f21bc3f81e7532fe1b5e1b486e6	doom19s.zip
> diff --git a/package/doom-wad/doom-wad.mk b/package/doom-wad/doom-wad.mk
> index 6f4f9da..6c870d0 100644
> --- a/package/doom-wad/doom-wad.mk
> +++ b/package/doom-wad/doom-wad.mk
> @@ -4,16 +4,18 @@
>  #
>  ################################################################################
>  
> -DOOM_WAD_VERSION = 1.8
> -DOOM_WAD_SOURCE = doom-$(DOOM_WAD_VERSION).wad.gz
> +DOOM_WAD_VERSION = 1.9
> +DOOM_WAD_SOURCE = doom19s.zip

So shouldn't the version be "19" and not "1.9" ? It is a bit weird to
have a version not used in the _SOURCE variable. Or if you really want
to have 1.9 as the version, then:

	DOOM_WAD_SOURCE = doom$(subst .,,$(DOOM_WAD_VERSION))s.zip

>  DOOM_WAD_SITE = ftp://ftp.idsoftware.com/idstuff/doom

However, the main reason I didn't apply is because this server seems to
be unavailable at the moment. So I can't test the package, and it would
cause build failures in the autobuilders.

Are you also experiencing the same issue?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-12-23 22:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 19:47 [Buildroot] [PATCH v4 1/3] chocolate-doom: new package Rodrigo Rebello
2015-11-06 19:47 ` [Buildroot] [PATCH v4 2/3] doom-wad: bump to version 1.9 Rodrigo Rebello
2015-12-23 22:37   ` Thomas Petazzoni [this message]
2015-12-23 23:59     ` Rodrigo Rebello
2015-12-24  7:28       ` Thomas Petazzoni
2015-11-06 19:47 ` [Buildroot] [PATCH v4 3/3] doom-wad: add BR2_PACKAGE_CHOCOLATE_DOOM as alternate dependency Rodrigo Rebello
2015-12-23 22:35   ` Thomas Petazzoni
2015-12-23 22:34 ` [Buildroot] [PATCH v4 1/3] chocolate-doom: new package Thomas Petazzoni
2015-12-24  0:33   ` Rodrigo Rebello
2015-12-24  7:29     ` Thomas Petazzoni
2015-12-24 11:11       ` Rodrigo Rebello
2016-02-21 16:23         ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151223233718.2703675c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox