From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 24 Dec 2015 15:26:32 +0100 Subject: [Buildroot] [PATCH v3 09/13] package/dhcp: SysV init scripts: remove PID files after stop In-Reply-To: <1445734779-7212-9-git-send-email-benoit.thebaudeau.dev@gmail.com> References: <1445734779-7212-1-git-send-email-benoit.thebaudeau.dev@gmail.com> <1445734779-7212-9-git-send-email-benoit.thebaudeau.dev@gmail.com> Message-ID: <20151224152632.7af2c1a1@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Beno?t, On Sun, 25 Oct 2015 02:59:35 +0200, Beno?t Th?baudeau wrote: > From: Beno?t Th?baudeau > > These daemons do not remove their PID files, so do it manually in the > scripts. > > Signed-off-by: Beno?t Th?baudeau I think this is not the right way of handling this and the IPv6 problem. What I would suggest is that the S80dhcp-server script should start two DHCP servers: one with -4 and one with -6. To avoid IPv6 failures, you can test if /proc/net/if_inet6 exists. Then, I was hoping you could use the --remove-pidfile option of start-stop-daemon, but it unfortunately doesn't exist in the Busybox implementation of start-stop-daemon. That being said, I still believe starting two daemons is the best solution. I don't think a Config.in option should be added for that. Just always start both, with as I propose an exception to not start the IPv6 daemon if /proc/net/if_inet6 does not exist. Could you rework your patches 9 to 13 with this goal in mind ? Thanks a lot! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com