From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain-external: CodeSourcery PowerPC: Revert the removal of CS PowerPC 2011.03
Date: Sat, 26 Dec 2015 16:42:10 +0100 [thread overview]
Message-ID: <20151226164210.2a30c04f@free-electrons.com> (raw)
In-Reply-To: <1451131225-9384-1-git-send-email-romain.naour@gmail.com>
Romain,
On Sat, 26 Dec 2015 13:00:25 +0100, Romain Naour wrote:
> Also re-add the old CS toolchain handling for pixman and liquid-dsp.
This part is not good. With your change, the "fixes" on pixman and
liquid-dsp are now also applied when using the SPE-capable 2012.03
toolchain, while in the past they were only used for the non-SPE
capable 2010.xx and 2011.xx toolchains:
-# Altivec detection isn't reliable for CS toolchains
-ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103)$(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009),y)
-PIXMAN_CONF_OPTS += --disable-vmx
-endif
config BR2_PACKAGE_LIQUID_DSP
bool "liquid-dsp"
depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL
depends on !BR2_STATIC_LIBS
- # These result in internal compiler error
- depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103
- depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009
help
Liquid-DSP is a free and open-source signal processing
library for software-defined radios written in C. Its
So either we need to have two Config.in symbols:
BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC and
BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC_SPE, or you need to adjust
the fixes to test that SPE is not set, like:
-ifeq ($(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC):$(BR2_POWERPC_CPU_HAS_SPE),y:)
-PIXMAN_CONF_OPTS += --disable-vmx
-endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-26 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 12:00 [Buildroot] [PATCH] toolchain-external: CodeSourcery PowerPC: Revert the removal of CS PowerPC 2011.03 Romain Naour
2015-12-26 15:42 ` Thomas Petazzoni [this message]
2015-12-26 20:37 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151226164210.2a30c04f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox