[Buildroot] [PATCHv2] toolchain: granular choice for stack protector

[Yann E. MORIN <yann.morin.1998@free.fr>]

Steven, All,

On 2015-12-27 02:44 -0800, Steven Noonan spake thusly:
> On Sun, Dec 27, 2015 at 2:26 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2015-12-27 11:19 +0100, Thomas Petazzoni spake thusly:
> >> On Sun, 27 Dec 2015 00:42:06 +0100, Yann E. MORIN wrote:
> >> > -config BR2_ENABLE_SSP
> >> > +choice
> >> >     bool "build code with Stack Smashing Protection"
> >> > -   depends on BR2_TOOLCHAIN_HAS_SSP
> >> > +   default BR2_SSP_ALL if BR2_ENABLE_SSP # legacy
> >> > +   default BR2_SSP_STRONG if BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> >>
> >> I don't understand this part. Why would we now defalut on
> >> BR2_SSP_STRONG if gcc >= 4.9 ?
> >
> > Hmmm... I did not think too much about that. I just "updated" the patch
> > and kept its meaning as-is.
> >
> >> I think we should keep the default of not having SSP enabled.
> >
> > Yes, makes sense. At best, the change in the default should have been in
> > another patch.
> 
> I could be wrong, but I *think* BuildRoot used to default to SSP on.
> If not, I don't know why I would have changed the default. I'm not a
> particularly big fan of SSP to begin with, so I'd have no incentive to
> default it enabled.

OK, so I will definitely remove the new defaults before I respin.

Thanks for the feedback! :-)

Regards,
Yann E. MORIN.

> > I'll fix and respin.
> >
> > Regards,
> > Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'