From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/jack2: add missing optional dependencies
Date: Mon, 28 Dec 2015 21:42:45 +0100 [thread overview]
Message-ID: <20151228214245.7b727b44@free-electrons.com> (raw)
In-Reply-To: <5f7632a3d6ed3e3ab0f324e31be21a0ea18245d4.1451329553.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Mon, 28 Dec 2015 20:08:55 +0100, Yann E. MORIN wrote:
> +ifeq ($(BR2_PACKAGE_OPUS),y)
> +JACK2_DEPENDENCIES += opus
> +endif
> +
> +ifeq ($(BR2_PACKAGE_READLINE),y)
> +JACK2_DEPENDENCIES += readline
> +endif
> +
> +ifeq ($(BR2_PACKAGE_EIGEN),y)
> +JACK2_DEPENDENCIES += eigen
> +endif
I'm fine with the opus and readline dependencies. But for the eigen
dependency, I'm not so sure. linux/wscript defines HAVE_EIGEN3 is eigen
is available. And this symbol is not used anywhere in the jack2 source
code... So it seems like eigen is a useless dependency.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-28 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 19:08 [Buildroot] [PATCH 0/2] jack2: add missing dependencies (branch yem/pw) Yann E. MORIN
2015-12-28 19:08 ` [Buildroot] [PATCH 1/2] package/eigen: install .pc file Yann E. MORIN
2015-12-28 21:05 ` Thomas Petazzoni
2015-12-28 21:13 ` Yann E. MORIN
2015-12-28 19:08 ` [Buildroot] [PATCH 2/2] package/jack2: add missing optional dependencies Yann E. MORIN
2015-12-28 20:42 ` Thomas Petazzoni [this message]
2015-12-28 20:49 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228214245.7b727b44@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox