From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] uboot: add COPY_OLD_LICENSE_FILE fix to rsync hook
Date: Tue, 29 Dec 2015 12:26:16 +0100 [thread overview]
Message-ID: <20151229122616.2ddd9ad0@free-electrons.com> (raw)
In-Reply-To: <1451356050-6300-1-git-send-email-nunes.erico@gmail.com>
Dear Erico Nunes,
On Tue, 29 Dec 2015 00:27:30 -0200, Erico Nunes wrote:
> make legal-info breaks when using an older u-boot version in local.mk
> with OVERRIDE_SRCDIR, due to the reorganization of license files which
> happened in u-boot v2013.10.
> This issue had already been fixed in Buildroot for the regular use of
> old u-boot versions (non-local.mk).
> This patch adds the same fix to UBOOT_POST_RSYNC_HOOKS so that it also
> covers the local.mk case.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
> boot/uboot/uboot.mk | 1 +
> 1 file changed, 1 insertion(+)
I am not super happy with having to duplicate all extract and patch
hooks as rsync hooks. The theory is that if you use a
<pkg>_OVERRIDE_SRCDIR, you should know what you're doing, and your
source tree should match the expectations of Buildroot.
But oh well, it kind of makes sense to help in this case, so I've
applied your patch. Still there is an open discussion on where to draw
the line for those post rsync hooks.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-29 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 2:27 [Buildroot] [PATCH 1/1] uboot: add COPY_OLD_LICENSE_FILE fix to rsync hook Erico Nunes
2015-12-29 11:26 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229122616.2ddd9ad0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox