Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] bcm2835: new package
Date: Tue, 29 Dec 2015 23:01:31 +0100	[thread overview]
Message-ID: <20151229230131.494ae5a0@free-electrons.com> (raw)
In-Reply-To: <1449609824-2649-1-git-send-email-ps.report@gmx.net>

Peter,

On Tue,  8 Dec 2015 22:23:44 +0100, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/Config.in            |  1 +
>  package/bcm2835/Config.in    | 10 ++++++++++
>  package/bcm2835/bcm2835.hash |  2 ++
>  package/bcm2835/bcm2835.mk   | 13 +++++++++++++
>  4 files changed, 26 insertions(+)
>  create mode 100644 package/bcm2835/Config.in
>  create mode 100644 package/bcm2835/bcm2835.hash
>  create mode 100644 package/bcm2835/bcm2835.mk

I've applied after doing a few changes:

    [Thomas:
     - addition of 'depends on BR2_arm' as suggested by Yann.
     - addition of a comment in the Config.in help text that says that
       this library is a pure abomination.
     - fix the hash, since apparently upstream changes the released
       tarballs after they are published.
     - fix license, it's GPLv2, not GPLv2+.]

If you could contact upstream to tell them to not change their tarballs
after they are published, it would be good. I had to change the hash
because yours wasn't matching the tarball I could download today, even
if the version hasn't changed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-12-29 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 21:23 [Buildroot] [PATCH v1] bcm2835: new package Peter Seiderer
2015-12-13 21:19 ` Yann E. MORIN
2015-12-17 21:20   ` Peter Seiderer
2015-12-29 22:01 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229230131.494ae5a0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox