From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] core/pkg-virtual: do not check they are neabled
Date: Wed, 30 Dec 2015 10:12:04 +0100 [thread overview]
Message-ID: <20151230101204.0f71f2d5@free-electrons.com> (raw)
In-Reply-To: <7048b92dbba0ba35f610d7863f0c599eca3e3399.1451430505.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Wed, 30 Dec 2015 00:10:40 +0100, Yann E. MORIN wrote:
> ifeq ($(MAKECMDGOALS),)
> - @if test "$($(PKG)_TYPE)" = "target" -a -z "$($($(PKG)_KCONFIG_VAR))" ; then \
> + @if test "$($(PKG)_TYPE)" = "target" \
> + -a ! "$($(PKG)_IS_VIRTUAL)" = "YES" \
I changed this to:
-a "$($(PKG)_IS_VIRTUAL)" != "YES" \
which I believe is a bit more logical.
> diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk
> index 9c68b51..244c1d0 100644
> --- a/package/pkg-virtual.mk
> +++ b/package/pkg-virtual.mk
> @@ -41,6 +41,8 @@ $$(error No implementation selected for virtual package $(1). Configuration erro
> endif
> endif
>
> +$(2)_IS_VIRTUAL = YES
I wasn't sure whether a new variable was needed. We could have used
$($(PKG)_VERSION) != "virtual", but that would have failed if one day
we have a normal package that really has a version named "virtual" for
some reason.
We can anyway change this later on if others have better suggestions.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-30 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 23:10 [Buildroot] [PATCH 0/3] core: add kconfigsymbols to packages (branch yem/check-target-packages) Yann E. MORIN
2015-12-29 23:10 ` [Buildroot] [PATCH 1/3] package/c-libraries: need linux-headers Yann E. MORIN
2015-12-30 9:10 ` Thomas Petazzoni
2015-12-29 23:10 ` [Buildroot] [PATCH 2/3] package/netbsd-queue: add Kconfig symbol like for all target packages Yann E. MORIN
2015-12-30 9:10 ` Thomas Petazzoni
2015-12-29 23:10 ` [Buildroot] [PATCH 3/3] core/pkg-virtual: do not check they are neabled Yann E. MORIN
2015-12-30 9:12 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151230101204.0f71f2d5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox