From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] openipmi: add OPENIPMI_VERSION_MAJOR variable
Date: Thu, 31 Dec 2015 10:31:41 +0100 [thread overview]
Message-ID: <20151231103141.580e0bfc@free-electrons.com> (raw)
In-Reply-To: <1451548770-2968-1-git-send-email-jerzy.grzegorek@trzebnica.net>
Jerzy,
On Thu, 31 Dec 2015 08:59:30 +0100, Jerzy Grzegorek wrote:
> -OPENIPMI_VERSION = 2.0.21
> -OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%202.0%20Library
> -OPENIPMI_SOURCE = OpenIPMI-2.0.21.tar.gz
> +OPENIPMI_VERSION_MAJOR = 2.0
> +OPENIPMI_VERSION = $(OPENIPMI_VERSION_MAJOR).21
> +OPENIPMI_SOURCE = OpenIPMI-$(OPENIPMI_VERSION).tar.gz
> +OPENIPMI_SITE = http://sourceforge.net/projects/openipmi/files/OpenIPMI%20$(OPENIPMI_VERSION_MAJOR)%20Library
I believe this is going a bit too far because what's encoded in the URL
here is not really the "major version", but the name of the project,
which is "OpenIPMI 2.0 Library".
So in this case, I don't think using the _VERSION_MAJOR thing is really
appropriate.
Let's see what others think about it.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-31 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 7:59 [Buildroot] [PATCH 1/1] openipmi: add OPENIPMI_VERSION_MAJOR variable Jerzy Grzegorek
2015-12-31 9:31 ` Thomas Petazzoni [this message]
2015-12-31 10:13 ` Arnout Vandecappelle
2016-01-01 17:19 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151231103141.580e0bfc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox